Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: Disable shadowstack #344292

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

chivay
Copy link
Member

@chivay chivay commented Sep 24, 2024

Description of changes

Similarly to zerocallusedregs, it breaks clang -target bpf calls.

Things done

Disable shadowstack for systemd. This fixes systemd build for pkgsExtraHardening.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Similarly to zerocallusedregs, it breaks clang -target bpf calls.
@LunNova
Copy link
Member

LunNova commented Sep 25, 2024

Result of nixpkgs-review pr 344292 run on x86_64-linux 1

9 packages built:
  • systemd
  • systemd.debug
  • systemd.dev
  • systemd.man
  • systemdUkify
  • systemdUkify.debug
  • systemdUkify.dev
  • systemdUkify.man
  • systemdgenie

@LunNova

This comment was marked as resolved.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 29, 2024
@arianvp arianvp merged commit b76cf73 into NixOS:staging Oct 1, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants