Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.cord-nvim: 2024-07-19 -> unstable-2024-09-26 #344478

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

redyf
Copy link
Member

@redyf redyf commented Sep 25, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@redyf redyf changed the title vimPlugins.cord-nvim: 2024-07-19 -> 2024-09-25 vimPlugins.cord-nvim: 2024-07-19 -> unstable-2024-09-26 Sep 27, 2024
@Eveeifyeve
Copy link
Contributor

Result of nixpkgs-review pr 344478 run on aarch64-darwin 1

2 packages built:
  • vimPlugins.cord-nvim
  • vimPluginsUpdater

@Eveeifyeve
Copy link
Contributor

So yeah it builds on macos.

Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 344478 run on x86_64-linux 1

2 packages built:
  • vimPlugins.cord-nvim
  • vimPluginsUpdater

CC @GaetanLepage

Copy link
Contributor

@Eveeifyeve Eveeifyeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, And Works.

Result of nixpkgs-review pr 345199 run on aarch64-darwin 1

4 packages built:
  • python311Packages.pyinstaller
  • python311Packages.pyinstaller.dist
  • python312Packages.pyinstaller
  • python312Packages.pyinstaller.dist

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@GaetanLepage GaetanLepage merged commit 2a5cba2 into NixOS:master Oct 3, 2024
25 of 26 checks passed
@redyf redyf deleted the cord-nvim branch October 4, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants