-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim: 9.1.0707 -> 9.1.0765 #347158
vim: 9.1.0707 -> 9.1.0765 #347158
Conversation
Yup I thought that too 😅 Rebasing on |
Fixes CVE-2024-47814 / GHSA-rj48-v4mq-j4vg. Changes: vim/vim@v9.1.0707...v9.1.0765
What was the ofborg rebuilds list before the force push? Edit: I guess we’ll see the same list now anyway, so no worries. |
... it's full of vimPlugins. https://gist.github.com/GrahamcOfBorg/905b1d3e525c759363eaeb4b026df9e6 |
Basically, I think we could merge this against master and it'd be fine. |
As @vcunat often says, Hydra’s bottlenecks are not what you expect: it’s not building large derivations that is necessarily the problem, but rather the job count, because of stuff around scheduling and compressing and uploading outputs that I don’t fully understand myself. I don’t know whether or not this would pass the threshold for being too much. |
The CVE doesn't seem urgent, but it's just the plugins. What about |
Successfully created backport PR for |
Yes, I believe so. It should get into |
Fixes CVE-2024-47814 / GHSA-rj48-v4mq-j4vg.
Changes:
vim/vim@v9.1.0707...v9.1.0765
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.