Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corerad: 1.3.0 -> 1.3.1, refactors #347280

Merged
merged 4 commits into from
Oct 13, 2024
Merged

Conversation

jmbaur
Copy link
Contributor

@jmbaur jmbaur commented Oct 8, 2024

This includes bumping corerad's version to 1.3.1, adding an update script so ryantm can handle automated updates, and moving to by-name with the new nixfmt changes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jmbaur
Copy link
Contributor Author

jmbaur commented Oct 8, 2024

@ofborg test corerad

@jmbaur jmbaur requested a review from mdlayher October 8, 2024 13:22
Copy link
Member

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's been a while since I've done this but seems fine.

@ofborg ofborg bot requested a review from mdlayher October 8, 2024 14:48
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 8, 2024
@jmbaur jmbaur mentioned this pull request Oct 9, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 9, 2024
@fabianhjr fabianhjr changed the title Various updates for corerad corerad: 1.3.0 -> 1.3.1, refactors Oct 13, 2024
@fabianhjr fabianhjr merged commit b70f5d7 into NixOS:master Oct 13, 2024
43 of 44 checks passed
@jmbaur jmbaur deleted the corerad-1.3.1 branch October 13, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants