Android Cross compilation #35451

Ericson2314 · 2018-02-24T07:52:30Z

Motivation for this change

I need to make sure GHC still works, but hydra is currently down.

Will be used by http://github.com/reflex-frp/reflex-platform

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

CC @bgamari @ElvishJerricco

GrahamcOfBorg · 2018-02-24T08:00:56Z

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/csms6c387h6d0fydplyg8hmhgfqngj75-glibc-iconv-2.26-131
/nix/store/nrkvd447jbjv9k9vil17vc09vb19jv5m-ncurses-6.0-20171125

GrahamcOfBorg · 2018-02-24T08:01:09Z

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/5hymrhfv7zm20ackp3i3di2n7amnlvva-libiconv-osx-10.11.6
/nix/store/a67rhbgwb41j11j6mgww3y0gq4pg0lmp-ncurses-6.0-20171125

GrahamcOfBorg · 2018-02-24T08:49:54Z

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/zxr2dbnrjfxlajc5r85y4rkfyzlpa779-glibc-iconv-2.26-131
/nix/store/069g827lh3hrhp4vkcq3rsh5jh65pm3l-ncurses-6.0-20171125

shlevy

Minor nits, but looks good!

shlevy · 2018-02-26T16:47:25Z

lib/systems/examples.nix

+    config = "aarch64-unknown-linux-android";
+    arch = "aarch64";
+    platform = platforms.aarch64-multiplatform;
+    useAndroidPrebuilt = true;


Would be good to document somewhere what this means.

Any idea where? The lib.system infra today currently doesn't offer for such ad-hoc top-level ones. And let's do the same for your isiPhoneSimulator too :D.

At the very least in the cross-compiling manual?

shlevy · 2018-02-26T16:51:08Z

pkgs/development/libraries/libiconv/default.nix

@@ -1,5 +1,6 @@
 { fetchurl, stdenv, lib
 , buildPlatform, hostPlatform
+, androidMinimal ? stdenv.hostPlatform.useAndroidPrebuilt


Nothing android specific about it, maybe give it a better name?

Yeah these two hacky (in that they do a bunch of mutually-unrelated random things) androidMinimal options were cargo-cults on my part. I've just been lacking the time to go back and empirically derive what's actually needed. Kinda want a "mea culpa style" name for that reason to acknowledge the tech debt, but I'm open to suggestions.

lightweight or minimal? Or if it makes more sense then maybe expose each change individually?

dtzWill

Visual review, haven't tried yet. Awesome to see this, thanks!

Shouldn't there be an RFC about this first?

dtzWill · 2018-02-26T17:55:34Z

pkgs/development/libraries/libiconv/default.nix

-  configureFlags =
-    lib.optional stdenv.isFreeBSD "--with-pic";
+  configureFlags = lib.optional stdenv.isFreeBSD "--with-pic"
+    ++ lib.optionals androidMinimal [ "--enable-static" "--without-cxx" ];


I don't think --without-cxx is a valid configure flag for libiconv, please remove if it isn't.

dtzWill · 2018-02-26T17:55:38Z

pkgs/development/libraries/ncurses/default.nix

+    #"--without-debug"
+    #"--without-termlib"
+    #"--without-ticlib"
+    "--without-cxx"


Probably want to remove all these commented-out lines, and de-duplicate what remains.

Just curious, why "--without-cxx"?

literally cargo culting some prior GHC on android work a year ago as per my comment above #35451 (comment), haha. I was too busy hacking up the first draft of everything we've merged since to look into this.

dtzWill · 2018-02-26T17:57:06Z

pkgs/development/mobile/androidenv/androidndk-pkgs.nix

+    libc = targetAndroidndkPkgs.libraries;
+    extraBuildCommands = lib.optionalString (targetPlatform.config == "arm-unknown-linux-androideabi") ''
+        sed -E \
+          -i $out/bin/${targetPlatform.config}-cc \


Doesn't hurt anything, but no reason to specify "-i" repeatedly. But keep it if you like it aesthetically.

oh I meant it to be -e repeatedly.

dtzWill · 2018-02-26T18:06:32Z

Also, does this work for you?

Trying to build coreutils:

$ nix build -f pkgs/top-level/release-cross.nix android64.coreutils
builder for '/nix/store/sgf8y6flk0md2yjrl701hhkp7labjszk-attr-2.4.47-aarch64-unknown-linux-android.drv' failed with exit code 77; last 10 log lines:
  fixing libtool script ./ltmain.sh
  configure flags: --disable-static --prefix=/nix/store/kfnhn1197c1qbha8fswl0dbk6nywpaa1-attr-2.4.47-aarch64-unknown-linux-android --bindir=/nix/store/4n7nkr8nrlv31n5d2jixsn6g2b00w47c-attr-2.4.47-aarch64-unknown-linux-android-bin/bin --sbindir=/nix/store/4n7nkr8nrlv31n5d2jixsn6g2b00w47c-attr-2.4.47-aarch64-unknown-linux-android-bin/sbin --includedir=/nix/store/88jqmlbagsiv3rmnjij85ac6yrkhg2kh-attr-2.4.47-aarch64-unknown-linux-android-dev/include --oldincludedir=/nix/store/88jqmlbagsiv3rmnjij85ac6yrkhg2kh-attr-2.4.47-aarch64-unknown-linux-android-dev/include --mandir=/nix/store/01mv8bnl4dw6yjlpjakpk4izzj71xs0b-attr-2.4.47-aarch64-unknown-linux-android-man/share/man --infodir=/nix/store/4n7nkr8nrlv31n5d2jixsn6g2b00w47c-attr-2.4.47-aarch64-unknown-linux-android-bin/share/info --docdir=/nix/store/bkpzzf59ihzapycyshqj8czyk02v9lk4-attr-2.4.47-aarch64-unknown-linux-android-doc/share/doc/ --libdir=/nix/store/kfnhn1197c1qbha8fswl0dbk6nywpaa1-attr-2.4.47-aarch64-unknown-linux-android/lib --libexecdir=/nix/store/kfnhn1197c1qbha8fswl0dbk6nywpaa1-attr-2.4.47-aarch64-unknown-linux-android/libexec --localedir=/nix/store/kfnhn1197c1qbha8fswl0dbk6nywpaa1-attr-2.4.47-aarch64-unknown-linux-android/share/locale MAKE=make MSGFMT=msgfmt MSGMERGE=msgmerge XGETTEXT=xgettext ECHO=echo SED=sed AWK=gawk --build=x86_64-unknown-linux-gnu --host=aarch64-unknown-linux-android
  checking build system type... x86_64-unknown-linux-gnu
  checking host system type... aarch64-unknown-linux-android
  checking how to print strings... printf
  checking for aarch64-unknown-linux-android-gcc... aarch64-unknown-linux-android-gcc
  checking whether the C compiler works... no
  configure: error: in `/build/attr-2.4.47':
  configure: error: C compiler cannot create executables
  See `config.log' for more details
cannot build derivation '/nix/store/pfr8dwlb6n7cxpm19xvn7ajsrl8vnw3d-coreutils-8.29-aarch64-unknown-linux-android.drv': 1 dependencies couldn't be built

Similar for ncurses, and such.

ElvishJerricco · 2018-02-26T17:29:35Z

pkgs/development/libraries/ncurses/default.nix

+    #"--without-debug"
+    #"--without-termlib"
+    #"--without-ticlib"
+    "--without-cxx"


Are these comments and duplicated --without-cxx important or can we clean this up?

It's only important insofar that it functions as a TODO.

Ericson2314 · 2018-02-27T18:07:23Z

@dtzWill Fixed a thing so it actually builds

Expose as an option for the cross stdenv.

Ericson2314 · 2018-02-27T23:04:30Z

Fixed and minimized the flags. @shlevy I'm going to document in a follow-up PR; It's possible I'll want to tweak how such ad-hoc attributes are used for a bit too, so the lib/systems/examples.nix example is probably a better stable interface for practical users anyways.

Ericson2314 requested review from shlevy, dtzWill and edolstra February 24, 2018 07:52

Ericson2314 requested a review from nbp as a code owner February 24, 2018 07:52

Ericson2314 added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Feb 24, 2018

GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 24, 2018

shlevy approved these changes Feb 26, 2018

View reviewed changes

dtzWill requested changes Feb 26, 2018

View reviewed changes

ElvishJerricco reviewed Feb 26, 2018

View reviewed changes

Ericson2314 added the 2.status: work-in-progress This PR isn't done label Feb 26, 2018

Ericson2314 changed the title ~~Andriod Cross compilation~~ Android Cross compilation Feb 27, 2018

Ericson2314 force-pushed the android-cross branch from 6378913 to 4d8254b Compare February 27, 2018 16:53

prebuilt android tools: Init using SDK

2482e28

Expose as an option for the cross stdenv.

Ericson2314 force-pushed the android-cross branch from 4d8254b to 2b896f9 Compare February 27, 2018 19:17

libiconv, ncurses: Add optional flags for minimal android variant

3a672cb

Ericson2314 force-pushed the android-cross branch from 2b896f9 to 3a672cb Compare February 27, 2018 22:56

Ericson2314 merged commit d31fb80 into NixOS:master Feb 27, 2018

Ericson2314 deleted the android-cross branch February 27, 2018 23:21

Ericson2314 restored the android-cross branch February 27, 2018 23:34

Ericson2314 deleted the android-cross branch February 27, 2018 23:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android Cross compilation #35451

Android Cross compilation #35451

Ericson2314 commented Feb 24, 2018

GrahamcOfBorg commented Feb 24, 2018

GrahamcOfBorg commented Feb 24, 2018

GrahamcOfBorg commented Feb 24, 2018

shlevy left a comment

shlevy Feb 26, 2018

Ericson2314 Feb 26, 2018

shlevy Feb 26, 2018

shlevy Feb 26, 2018

Ericson2314 Feb 26, 2018

shlevy Feb 26, 2018

dtzWill left a comment

dtzWill Feb 26, 2018

dtzWill Feb 26, 2018

Ericson2314 Feb 26, 2018 •

edited

Loading

dtzWill Feb 26, 2018

Ericson2314 Feb 26, 2018

dtzWill commented Feb 26, 2018

ElvishJerricco Feb 26, 2018

Ericson2314 Feb 26, 2018

Ericson2314 commented Feb 27, 2018

Ericson2314 commented Feb 27, 2018

Android Cross compilation #35451

Android Cross compilation #35451

Conversation

Ericson2314 commented Feb 24, 2018

Motivation for this change

Things done

GrahamcOfBorg commented Feb 24, 2018

GrahamcOfBorg commented Feb 24, 2018

GrahamcOfBorg commented Feb 24, 2018

shlevy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dtzWill left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ericson2314 Feb 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dtzWill commented Feb 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ericson2314 commented Feb 27, 2018

Ericson2314 commented Feb 27, 2018

Ericson2314 Feb 26, 2018 •

edited

Loading