Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel-headers: remove deprecated and broken asm symlink fixups #36366

Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 6, 2018

Replaces #36303.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dezgeg
Copy link
Contributor

dezgeg commented Mar 6, 2018

LGTM, though you could have a link to the discussion in #36303 on the commit message.

BTW, staging has quite a bit of unmerged stuff so might not want to merge this just yet.

@dtzWill dtzWill force-pushed the fix/kernel-header-asm-symlinks-remove branch from 974ff77 to 3a40b33 Compare March 6, 2018 17:14
@dtzWill
Copy link
Member Author

dtzWill commented Mar 6, 2018

Good call, updated the commit. Happy to wait re:merging to staging, but not sure how to know when it's in a better condition. Should I just ping this in a few days? :)

cc NixOS/rfcs#26 re:staging workflow .

(this is low-priority but will cause lots of rebuilds, while also being rather low risk in terms of "let's see if anything breaks")

@dtzWill dtzWill merged commit 0e01430 into NixOS:staging Mar 11, 2018
@dtzWill dtzWill deleted the fix/kernel-header-asm-symlinks-remove branch March 11, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants