Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Geant4 Monte Carlo radiation transport toolkit and its Python bindings. #3963

Merged
merged 2 commits into from
Oct 2, 2014
Merged

Add the Geant4 Monte Carlo radiation transport toolkit and its Python bindings. #3963

merged 2 commits into from
Oct 2, 2014

Conversation

christopherpoole
Copy link
Contributor

No description provided.

@7c6f434c
Copy link
Member

7c6f434c commented Sep 4, 2014

Is there a reason to package multiple patchlevels of the previous major version (with the same minor version) from the get-go?

@christopherpoole
Copy link
Contributor Author

When publishing research, authors will make reference to the specific
patched version they used for their simulations. For validation of results
it is important to work with the correct patch version, and subsequently
examine improvements brought about by the latest version. The changes added
to patches are not always trivial when considering the simulation output.
They may make no difference to the software from a development point of
view however.

I will also note that Geant4 has a fixed and regular versioning and release
cycle that is broadly independent of changes made.
On 05/09/2014 3:08 am, "Michael Raskin" notifications@github.com wrote:

Is there a reason to package multiple patchlevels of the previous major
version (with the same minor version) from the get-go?


Reply to this email directly or view it on GitHub
#3963 (comment).

@edolstra
Copy link
Member

edolstra commented Sep 5, 2014

I don't think we should keep multiple versions around to make research results reproducible. If people require that, they should either:

  • Record the exact Nixpkgs version used (i.e. the Git commit hash). This way you reproduce everything, including all dependencies.
  • Make a private copy of the Geant Nix expression.

@christopherpoole
Copy link
Contributor Author

Good point. I didn't really consider option one; which is a more powerful
solution.

What I can do is resubmit a pull request including the latest version only,
ignoring older versions. As new versions are released I can update
accordingly. It is then up to the user if they seek older patches or
versions.

This pull request as is, is useful for me, however probably not for the
general case.
On 05/09/2014 7:21 pm, "Eelco Dolstra" notifications@github.com wrote:

I don't think we should keep multiple versions around to make research
results reproducible. If people require that, they should either:

Record the exact Nixpkgs version used (i.e. the Git commit hash). This
way you reproduce everything, including all dependencies.

Make a private copy of the Geant Nix expression.


Reply to this email directly or view it on GitHub
#3963 (comment).

@7c6f434c
Copy link
Member

7c6f434c commented Sep 5, 2014

This pull request as is, is useful for me, however probably not for the
general case.

You can push a PR where you add all versions you would ever want and
immediately remove all but the latest minors for major branches…

You can locally tag this revision and have quick and easy access to
older versions (checkout the tag and build).

@Fuuzetsu
Copy link
Member

@christopherpoole Can you update the PR as per comments, only keeping the latest version?

7c6f434c added a commit that referenced this pull request Oct 2, 2014
Add the Geant4 Monte Carlo radiation transport toolkit and its Python bindings.
@7c6f434c 7c6f434c merged commit 907af9e into NixOS:master Oct 2, 2014
@knedlsepp
Copy link
Member

I was just working my way through all the motif packages. I can't evaluate this expression. This is due to the missing license "g4sl" (https://geant4.web.cern.ch/geant4/license/LICENSE.html) in the licenses.nix file.

knedlsepp added a commit to knedlsepp/nixpkgs that referenced this pull request Jul 31, 2016
This license was left out during the geant4 pull request:
NixOS#3963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants