-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qscintilla: revert bump to fix the build #39860
Conversation
Success on x86_64-linux (full log) Attempted: libsForQt5.qscintilla Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: libsForQt5.qscintilla Partial log (click to expand)
|
@Ma27 Added issue to blacklist this for nixpkgs-update |
(short side note, I'm currently running
This is definetely an appropriate measure to do for now I guess, however I think that the core issue behind the breakage we experience is a different one: several packages in One example is |
|
Instead of reverting, I would much rather that we keep a separate |
@Ma27 There's a version bump (to 2.10.4) which fixes the qt4 variant It allows Octave to build on my workstation, so at least that works. |
@peterhoeg I'd actually agree with you, however The main reason for this is that in 3391006 was added a darwin compliancy patch from the homebrew repository which fixes the XCode build of As you can see on the |
Thanks for doing this - you are absolutely right. |
Motivation for this change
This reverts the bump of
qscintilla
performed in #37330 as it actively breaks the qt5-darwin support added in 7343238.Furthermore #37330 (namely 8ee6a03) never worked when building the
qt4
variantnix-build -A qscintilla
.The original bump broke the following packages transitively:
As I don't have the required resources to actively test/maintain the darwin compatibility of
qscintilla
and theqt4
variant never worked since the bump, I'd vote to revert the change for now and perform a bump with testedqt4
anddarwin
derivations./cc @ryantm @mpickering @peterhoeg
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)