network-manager: 1.10.6 → 1.12.0 #43087
Conversation
GrahamcOfBorg
added
10.rebuild-darwin: 0
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: networkmanager, networkmanager-openvpn Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: networkmanager, networkmanager-openvpn Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: networkmanager, networkmanager-openvpn Partial log (click to expand)
|
|
Did give this a try. I'm still not quite sure if everything is correctly, though: After cherry-picking and rebuilding my user profile (with the newer After rebuilding the system itself too, and restarting network-manager and This now happens with other VPN flavours that previously worked (vpnc for example). Initiating the |
|
As for the segfault currently happening on unstable: |
|
|
|
LGTM. Rebooted into this PR (you know what I mean) and VPN works as usual (on 18.03). (don't know about the issues brought up, sorry) |
|
I can confirm a segfault when trying to add any VPN connection using nm-applet in Xfce, no matter the presence of the gnome-keyring. The following messages are logged to journal: And this is the stack trace: System configuration{ config, pkgs, ... }:
with { inherit (pkgs) enableDebugging; };
{
environment.systemPackages = with pkgs; [
gdb
];
nixpkgs.config.packageOverrides = super: {
networkmanager = enableDebugging super.networkmanager;
networkmanagerapplet = enableDebugging super.networkmanagerapplet;
};
networking.networkmanager.enable = true;
services.xserver.enable = true;
services.xserver.libinput.enable = true;
services.xserver.displayManager.lightdm.enable = true;
services.xserver.desktopManager.xfce.enable = true;
# services.gnome3.gnome-keyring.enable = true;
services.openssh.enable = true;
environment.enableDebugInfo = true;
systemd.coredump.enable = true;
users.extraUsers.guest = {
isNormalUser = true;
uid = 1000;
initialPassword = "";
extraGroups = ["users" "wheel" "networkmanager"];
openssh.authorizedKeys.keys = [...];
};
} |
|
Incredibly, the dialogue is displayed fine when nm-connection-editor is running. Opened an upstream issue https://gitlab.gnome.org/GNOME/network-manager-applet/issues/9 |
|
It's strange to me the problem occurs for me on master-ish--same double-free AFAICT-- but is fixed by either this PR or #43123. In neither situation do I have the connection editor open, although the dialog does display briefly (it always has for me, including on 18.03 and earlier). I do tend to issue Hope this helps... (I do have nm-applet running, but not the connection editor, FWIW) |
Password entering should now work even without GNOME Keyring: https://gitlab.gnome.org/GNOME/network-manager-applet/issues/3
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: networkmanager, networkmanager-openvpn Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: networkmanager, networkmanager-openvpn Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: networkmanager, networkmanager-openvpn Partial log (click to expand)
|
Looks like this was fixed upstream? Would it make sense to pick this patch to address the issue (while waiting for next release)? |
|
@dtzWill I already did that before merging https://github.com/NixOS/nixpkgs/pull/43087/files#diff-f8870604db2c9e88b1a23bac47f7dfc9R20 😉 |
Haha of course! Awesome, my mistake :D. |
|
Could someone try https://gitlab.gnome.org/GNOME/network-manager-applet/issues/12#note_272894 and https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/15? I am away this week. |
|
@jtojnar the first one is already covered by #44037. |
|
Yes, the import menu item is only shown when there are no VPNs configured (e.g. in VM). |
|
got it - will update above PR to include these changes as well |
Motivation for this change
https://blogs.gnome.org/lkundrak/2018/06/29/networkmanager-1-12/
There is now a meson support in network-manager but we cannot use it since it always tries to build docs (attempt here). It fails because docs generator uses GObject introspection but we are patching
g-ir-scannerto produce absolute paths, which, of course, do not exist before installation.Upstream now disables the legacy
nm-glibby default, we are enabling it here since some packages probably still rely on it. Is there a way to find those packages?cc @obadz Password entering in nm-applet should now work even without GNOME Keyring: https://gitlab.gnome.org/GNOME/network-manager-applet/issues/3
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)