Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl-cross: 1.1.8 -> 1.2, needed for newer perl versions #43858

Merged
merged 2 commits into from
Jul 20, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 20, 2018

1.1.8 does not support the versions of perl in-tree.

As a result cross-compiling fails at perl which
blocks quite a few things :).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mostly tested that this builds, with bias towards musl platforms O:).

Things like:

  • $ nix build -f . pkgsCross.musl64.perl -o perl-cross-musl64
  • $ nix build -f . pkgsCross.aarch64-multiplatform-musl.perl -o perl-cross-aarch64

cc @shlevy in case there's anything in particular that should be tested...?

Copy link
Member

@shlevy shlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jul 20, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: perl

Partial log (click to expand)

/nix/store/66103yn34knil01sz58z2fk4p2ly8dw3-perl-5.24.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: perl

Partial log (click to expand)

/nix/store/pngyllkbhkjvbkmwg1k6nhf1mx9775w6-perl-5.24.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: perl

Partial log (click to expand)

/nix/store/7dn8rrvjmigv13wgzlmgdg2l4m6q6bwx-perl-5.24.4

@dtzWill dtzWill merged commit ce12ad3 into NixOS:master Jul 20, 2018
@dtzWill dtzWill deleted the update/perl-cross-1.2 branch July 20, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants