Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager-vpnc: 1.2.4 -> 1.2.6 #44031

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

andir
Copy link
Member

@andir andir commented Jul 23, 2018

Motivation for this change

fixes CVE-2018-10900

(cherry picked from commit f4f8cb5)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir andir requested a review from jtojnar July 23, 2018 21:25
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 23, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: networkmanager-vpnc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: networkmanager-vpnc

Partial log (click to expand)

shrinking /nix/store/z52rss218x8imp6wg36h1d20l9kwf0dz-NetworkManager-vpnc-gnome-1.2.6/libexec/nm-vpnc-auth-dialog
shrinking /nix/store/z52rss218x8imp6wg36h1d20l9kwf0dz-NetworkManager-vpnc-gnome-1.2.6/libexec/nm-vpnc-service-vpnc-helper
shrinking /nix/store/z52rss218x8imp6wg36h1d20l9kwf0dz-NetworkManager-vpnc-gnome-1.2.6/libexec/nm-vpnc-service
shrinking /nix/store/z52rss218x8imp6wg36h1d20l9kwf0dz-NetworkManager-vpnc-gnome-1.2.6/lib/NetworkManager/libnm-vpn-plugin-vpnc.so
shrinking /nix/store/z52rss218x8imp6wg36h1d20l9kwf0dz-NetworkManager-vpnc-gnome-1.2.6/lib/NetworkManager/libnm-vpn-plugin-vpnc-editor.so
shrinking /nix/store/z52rss218x8imp6wg36h1d20l9kwf0dz-NetworkManager-vpnc-gnome-1.2.6/lib/NetworkManager/libnm-vpnc-properties.so
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/z52rss218x8imp6wg36h1d20l9kwf0dz-NetworkManager-vpnc-gnome-1.2.6/lib  /nix/store/z52rss218x8imp6wg36h1d20l9kwf0dz-NetworkManager-vpnc-gnome-1.2.6/libexec
patching script interpreter paths in /nix/store/z52rss218x8imp6wg36h1d20l9kwf0dz-NetworkManager-vpnc-gnome-1.2.6
checking for references to /build in /nix/store/z52rss218x8imp6wg36h1d20l9kwf0dz-NetworkManager-vpnc-gnome-1.2.6...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: networkmanager-vpnc

Partial log (click to expand)

shrinking /nix/store/awqzr3bijmbrzn3hc9w07njhvq2z2wcm-NetworkManager-vpnc-gnome-1.2.6/lib/NetworkManager/libnm-vpn-plugin-vpnc-editor.so
shrinking /nix/store/awqzr3bijmbrzn3hc9w07njhvq2z2wcm-NetworkManager-vpnc-gnome-1.2.6/lib/NetworkManager/libnm-vpn-plugin-vpnc.so
shrinking /nix/store/awqzr3bijmbrzn3hc9w07njhvq2z2wcm-NetworkManager-vpnc-gnome-1.2.6/libexec/nm-vpnc-auth-dialog
shrinking /nix/store/awqzr3bijmbrzn3hc9w07njhvq2z2wcm-NetworkManager-vpnc-gnome-1.2.6/libexec/nm-vpnc-service-vpnc-helper
shrinking /nix/store/awqzr3bijmbrzn3hc9w07njhvq2z2wcm-NetworkManager-vpnc-gnome-1.2.6/libexec/nm-vpnc-service
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/awqzr3bijmbrzn3hc9w07njhvq2z2wcm-NetworkManager-vpnc-gnome-1.2.6/lib  /nix/store/awqzr3bijmbrzn3hc9w07njhvq2z2wcm-NetworkManager-vpnc-gnome-1.2.6/libexec
patching script interpreter paths in /nix/store/awqzr3bijmbrzn3hc9w07njhvq2z2wcm-NetworkManager-vpnc-gnome-1.2.6
checking for references to /build in /nix/store/awqzr3bijmbrzn3hc9w07njhvq2z2wcm-NetworkManager-vpnc-gnome-1.2.6...
/nix/store/awqzr3bijmbrzn3hc9w07njhvq2z2wcm-NetworkManager-vpnc-gnome-1.2.6

@Mic92 Mic92 merged commit 1caae72 into NixOS:release-18.03 Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants