-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Studio improvements #44310
Android Studio improvements #44310
Conversation
Hope this is ok... :)
IMO it makes sense that the other channels show up in nix-env as well.
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: android-studio-preview Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: android-studio-preview Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: android-studio-preview Partial log (click to expand)
|
I think this broke evaluation https://gist.github.com/GrahamcOfBorg/6b399b49b5528b9befa525051bd2c2f9 |
@LnL7 Looking at the last line:
I think this was actually due to e090fb2, but thank you very much for the notification anyway 😄. From the fist lines it definitely looks like this PR is responsible:
But that's actually supposed to be there (when building android-studio-preview or androidStudioPackages.preview), I'm not sure if that was a good idea though, let's hope this doesn't cause any problems with Hydra... (if it does or if we don't want this, we can revert 88bfbf6) |
There were apparently two problems at that point. ATM reverting your commit fixed the tarball job for me, so I pushed that. Maybe this is doable by fixing the tarball job instead, but at least for now... EDIT: log, as Hydra's are badly shown now:
|
This reverts commit 88bfbf6. It broke the tarball job. Discussion: #44310 (comment)
AFAIK we don't yet have a good way of deprecating attribute paths in nixpkgs. (We do for NixOS options.) I've tried to fight this at some point, but I haven't managed a way (yet). It usually boils down to the inability to differentiate between explicit usage of an attribute and listing via |
@vcunat Thank you very much for reverting it and sorry for any inconvenience caused (was hoping it would be fine...). |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)