Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bison: 3.2.4 -> 3.3 #54635

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
4 participants
@dtzWill
Copy link
Contributor

commented Jan 26, 2019

Motivation for this change

https://lists.gnu.org/archive/html/bison-announce/2019-01/msg00002.html

Have not build-tested it yet, and should at the very least check
Nix still builds with this new version :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill changed the title bison: 3.2.4 -> 3.3 bison: 3.2.4 -> 3.3.1 Jan 27, 2019

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2019

@GrahamcOfBorg build bison nix

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

Works for building my systems, looks good!

@dtzWill dtzWill merged commit f235d64 into NixOS:staging Jan 29, 2019

10 of 16 checks passed

bison on aarch64-linux Unexpected error: command failed with exit code 1
Details
bison on x86_64-darwin Timed out, unknown build status
Details
bison on x86_64-linux Unexpected error: command failed with exit code 1
Details
bison, nix on aarch64-linux Failure
Details
bison, nix on x86_64-darwin Timed out, unknown build status
Details
bison, nix on x86_64-linux Failure
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@dtzWill dtzWill deleted the dtzWill:update/bison-3.3 branch Jan 29, 2019

@vcunat

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

Then it's weird that not even glibc builds here: #54870 (comment) (I can reproduce that)

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

Then it's weird that not even glibc builds here: #54870 (comment) (I can reproduce that)

That is weird. I thought I must have been mistaken but nope glibc builds fine here, and indeed the glibc for my currently booted system was built w/bison 3.3.1. Strange. Well it may need to be reverted if goes beyond the one issue, sorry about that!

@vcunat

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

I suppose the breakages won't be too bad. Most of problematic packages should be fixable simply by switching to bison2.

vcunat added a commit that referenced this pull request Jan 29, 2019

@vcunat vcunat changed the title bison: 3.2.4 -> 3.3.1 bison: 3.2.4 -> 3.3 Jan 29, 2019

@dtzWill dtzWill referenced this pull request Jan 29, 2019

Merged

bison: 3.3 -> 3.3.1 #54878

0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.