wrapGAppsHook: add package’s own modules to GIO_EXTRA_MODULES

[jtojnar]

Motivation for this change

When a package provides both executables and gio modules, it is quite
probable the executables will need those modules. wrapGAppsHook wraps
executables with GIO_EXTRA_MODULES picked up from dependencies
but forgets about the package being built. Let’s add to consideration.

Closes: #50254

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[jtojnar]

$ cat $(nix-build -A gvfs)/libexec/gvfsd-fuse | rg GIO_EXTRA_MODULES
export GIO_EXTRA_MODULES='/nix/store/hvdwscbv3w6f5wr7liri89g473v6r6v9-dconf-0.30.1-lib/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES
export GIO_EXTRA_MODULES='/nix/store/hvdwscbv3w6f5wr7liri89g473v6r6v9-dconf-0.30.1-lib/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES
export GIO_EXTRA_MODULES='/nix/store/27yrqjjig6qz3hbkzpkwivmzakas5lw5-gvfs-1.38.1/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES

[hedning]

Looks good to me. A bit weird that eg. dconf is written twice, but that's another issue as far as I understand.

[jtojnar]

Yeah, our setup hooks are not well written 😁

However, a dependency specified twice will have its setup hook run twice, and that could easily change the build environment (though a well-written setup hook will therefore strive to be idempotent so this is in fact not observable).

—https://nixos.org/nixpkgs/manual/#ssec-setup-hooks

Edit: split off an issue #57638

[worldofpeace]

Do we still need https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/x11/desktop-managers/gnome3.nix#L202?

[jtojnar]

I would remove it but there are still many unwrapped apps (QT). Maybe we could add an gnome3.enableImpureClusterfuck option and disable it by default.

[worldofpeace]

I would remove it but there are still many unwrapped apps (QT).

Aren't wrappers for QT apps incoming? So maybe removing it completely isn't far off.

should open an issue to streamline us dropping it?

Maybe we could add an gnome3.enableImpureClusterfuck option and disable it by default.

Well that does get the point across just fine 👍
But maybe it's not in our best interest to start hiding things, so when the time is right.

[jtojnar]

Aren't wrappers for QT apps incoming?

That still seems to be a far off. And they do not include GNOME hooks, IIRC.