Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.bjoern: 2.2.3 -> 3.0.1 #62840

Merged
merged 1 commit into from
Jun 8, 2019
Merged

pythonPackages.bjoern: 2.2.3 -> 3.0.1 #62840

merged 1 commit into from
Jun 8, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 7, 2019

Motivation for this change

Upstream has addressed issues noted in #62055 and made a new release. This should supersede #62055 and #61887.

Test execution seems a little unusual/hit-and-miss for me on macos (tested 10.13), but the exact same problem appears to exist with 2.2.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner June 7, 2019 22:04
@marsam
Copy link
Contributor

marsam commented Jun 7, 2019

@GrahamcOfBorg build pythonPackages.bjoern python3Packages.bjoern

@marsam marsam mentioned this pull request Jun 7, 2019
Closed
@marsam marsam merged commit d09e670 into NixOS:master Jun 8, 2019
@marsam
Copy link
Contributor

marsam commented Jun 8, 2019

Thanks @risicle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@risicle @marsam