libclc: 2017-11-29 -> 2019-06-09

[athas]

Motivation for this change

The old version does not compile at all with the current default LLVM in Nixpkgs. This one does.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[matthewbauer]

@GrahamcOfBorg build libclc

[aanderse]

@athas can you please address the build failure?

[athas]

I don't know why it's trying to build for aarch64. The targets libclc lists as supported are all NVIDIA and AMD GPU architectures. Is there a way to find out whether the current libclc used to build on aarch64? (It certainly doesn't now - it does not build on anything.)

[yorickvP]

platforms.x86_64?

[athas]

If the aarch64 failure is a blocker for 19.09 (note the current libclc does not work at all on any platform), I recommend just disabling aarch64 (no idea how). I have no way to debug it, since I do not have access to an aarch64 machine.

[athas]

I managed to find an aarch64 machine and fix the issue, I think.

[athas]

Relevant for #68361.

[aanderse]

@GrahamcOfBorg build libclc

[aanderse]

@athas please rebase on master and remove the broken bit.

[athas]

Done!

[aanderse]

@athas looks like there are still issues.

[athas]

Looks like some of my changes got lost in the rebase. Should work now.

[aanderse]

@athas looks like something else went wrong with your push: undefined variable 'clang-unwrapped'

[athas]

Alright, check it out now.

[aanderse]

@matthewbauer are you familiar with this library at all? If so... care to take over from here? 😄

[athas]

Any news here? As stated in the original PR, the current libclc simply doesn't work (and is barely used for anything; my motivation is eventually fixing Mesa), so this cannot possibly go wrong.

[vcunat]

Let's re-check the builds.
@GrahamcOfBorg build libclc

[vcunat]

It seems a bit suspicious to use wrapped bin/clang++ and unwrapped bin/clang, but if it seems to work, it's surely better than a package that doesn't even build.