Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.ms-vscode.cpptools: 0.23.1 -> 0.24.0 #64429

Merged
merged 1 commit into from
Jul 9, 2019
Merged

vscode-extensions.ms-vscode.cpptools: 0.23.1 -> 0.24.0 #64429

merged 1 commit into from
Jul 9, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jul 8, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jul 8, 2019

@GrahamcOfBorg eval

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 8, 2019
@eadwu eadwu force-pushed the vscode-extensions.ms-vscode.cpptools/0.24.0 branch from 931efb4 to 79907db Compare July 8, 2019 23:44
@eadwu eadwu force-pushed the vscode-extensions.ms-vscode.cpptools/0.24.0 branch from 79907db to ca13e2b Compare July 8, 2019 23:56
@worldofpeace worldofpeace merged commit bf7ab59 into NixOS:master Jul 9, 2019
@eadwu eadwu deleted the vscode-extensions.ms-vscode.cpptools/0.24.0 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eadwu @grahamc @worldofpeace