Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

love_0_8: fix broken build #68467

Merged
merged 1 commit into from
Sep 11, 2019
Merged

love_0_8: fix broken build #68467

merged 1 commit into from
Sep 11, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

#68361
#68209

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from 7c6f434c September 11, 2019 01:12
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 11, 2019
ivan
ivan approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this fixes the build on NixOS x86_64.

@teto
Copy link
Member

teto commented Sep 11, 2019

@GrahamcOfBorg build love_0_8

@worldofpeace worldofpeace merged commit 85c5c3a into NixOS:master Sep 11, 2019
@worldofpeace
Copy link
Contributor

backported in 69a371b

@aanderse
Copy link
Member Author

Thank you @worldofpeace!

@aanderse aanderse deleted the zhf/love_0_8 branch September 11, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aanderse @teto @worldofpeace @ivan