Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mtr: support for selecting the package #68507

Merged
merged 2 commits into from
Sep 12, 2019
Merged

nixos/mtr: support for selecting the package #68507

merged 2 commits into from
Sep 12, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

mtr comes in both a CLI and GUI version, so allow us to configure which one to use.

We now also expose the gui option.

gtk2 -> gtk3 has been merged upstream, so that will come in the next release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package labels Sep 11, 2019
@ofborg ofborg bot requested review from globin and 7c6f434c September 11, 2019 16:21
@Ma27 Ma27 merged commit 99b291c into NixOS:master Sep 12, 2019
@peterhoeg peterhoeg deleted the f/mtr branch September 12, 2019 08:55
@peterhoeg peterhoeg restored the f/mtr branch September 12, 2019 09:55
@peterhoeg peterhoeg deleted the f/mtr branch September 13, 2019 09:52
@peterhoeg peterhoeg restored the f/mtr branch September 13, 2019 11:03
@peterhoeg peterhoeg deleted the f/mtr branch September 24, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@globin globin Awaiting requested review from globin

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterhoeg @Ma27