Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: fix darwin build #70215

Merged
merged 2 commits into from
Oct 4, 2019
Merged

neovim: fix darwin build #70215

merged 2 commits into from
Oct 4, 2019

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Oct 1, 2019

Motivation for this change

This is pretty hacky and I don't really understand the reasoning behind luv vs libluv.

Fixes #70077

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7
lua.pkgs.luv.libluv: fix linking against lua on darwin
fc408c8 
    [ 50%] Building C object CMakeFiles/luv.dir/src/luv.c.o
    [100%] Linking C shared library libluv.dylib
    Undefined symbols for architecture x86_64:
      "_luaL_addlstring", referenced from:
          _thread_dump in luv.c.o
      ...
@LnL7
neovim: link against libluv on darwin
c819648
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: lua labels Oct 1, 2019
@ofborg ofborg bot requested a review from manveru October 1, 2019 22:57
@teto
Copy link
Member

teto commented Oct 2, 2019

@GrahamcOfBorg build neovim

@teto
Copy link
Member

teto commented Oct 2, 2019

@malob can you check it fixes your issue ?

@malob
Copy link
Member

malob commented Oct 2, 2019

@teto, just ran nix-shell -p nix-review --run "nix-review pr 70215" on my macOS and it produced no errors. I think we are good to go 😄. (Floating windows here I finally come!)

@teto
Copy link
Member

teto commented Oct 4, 2019

ran nix-review on linux, neovim-qt/neovim work. Finally everyone can enjoy the pure bliss of neovim 0.4.X (while waiting for treesitter integration in 0.5 !)

@teto teto merged commit 81487f7 into NixOS:master Oct 4, 2019
@LnL7 LnL7 deleted the darwin-lua-libluv branch October 4, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: lua 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lua.pkgs.luv.libluv fails to build on Darwin which causes Neovim to fail to build as well
3 participants
@LnL7 @teto @malob