-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZminc: 2017-08-29 -> 2019-07-25; unbreak ezminc and pyezminc #71708
Conversation
3ae7689
to
0cc85b8
Compare
please squash the commits should just have one
|
Only make a single commit for these two packages? |
correct, it will also be easier to cherry-pick if it's a single commit |
0cc85b8
to
78b13cc
Compare
@jonringer squashed |
please edit the commit subject to be : |
But that's not the change that has been made (pyezminc's version wasn't changed). |
oh wow, it looked like the same file to me when I was reviewing... So sorry, yes, please have 1 commit per package. you probably had it right the first time. I apologize |
78b13cc
to
f0939e9
Compare
@jonringer -- done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM
executables seem to work
[4 built, 3 copied (95.5 MiB), 13.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71708
2 package were build:
ezminc python27Packages.pyezminc
Thanks! |
Motivation for this change
Fix these packages for ZHF (#68361).
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @