Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/kubernetes: ensure kubelet cert contains a well-formed user #73139

wants to merge 2 commits into
base: master


Copy link

kragniz commented Nov 9, 2019

If the hostname is empty, this otherwise gets generated as
system:node:, which causes problems during node registration.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @

If the hostname is empty, this otherwise gets generated as
`system:node:`, which causes problems during node registration.
Copy link

endocrimes left a comment

Small consistency suggestions but otherwise this LGTM.

Co-Authored-By: Danielle <>

This comment has been minimized.

Copy link
Member Author

kragniz commented Nov 10, 2019

@endocrimes good suggestion, applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.