Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iojs: Update to 1.8.1 #7508

Closed
wants to merge 1 commit into from
Closed

iojs: Update to 1.8.1 #7508

wants to merge 1 commit into from

Conversation

Havvy
Copy link
Contributor

@Havvy Havvy commented Apr 22, 2015

Ran the update script.

@Havvy
Copy link
Contributor Author

Havvy commented Apr 22, 2015

The TravisCI error is unrelated to this package.

@the-kenny
Copy link
Contributor

On NixOS:

building path(s) ‘/nix/store/by0p2sxcxy0zjzza8kmjmvz82vdxigxv-iojs-1.8.1’
unpacking sources
unpacking source archive /nix/store/5bkdnby1bm1585q1bdr7saifkafj4bin-iojs-v1.8.1.tar.gz
source root is iojs-v1.8.1
patching sources
configuring
configure flags: --disable-static --prefix=/nix/store/by0p2sxcxy0zjzza8kmjmvz82vdxigxv-iojs-1.8.1 --shared-openssl --shared-http-parser --shared-zlib --shared-libuv 
Usage: configure [options]

configure: error: no such option: --disable-static
builder for ‘/nix/store/39cpn90kv55ahrbb0159qc1lm2hnf1y1-iojs-1.8.1.drv’ failed with exit code 2
error: build of ‘/nix/store/39cpn90kv55ahrbb0159qc1lm2hnf1y1-iojs-1.8.1.drv’ failed

@lucabrunox
Copy link
Contributor

@Havvy when running the update script you should also actually build the package, please. We have hard times trusting submitters otherwise.

@Havvy
Copy link
Contributor Author

Havvy commented Apr 23, 2015

Sorry, I was expecting that the build process wouldn't change in 12 days, and was building rustc yesterday. I'll build it in the future..

Now, I can't actually figure out where the configure flag is coming from. It's not in /pkgs/development/web/iojs/default.nix nor is it mentioned in the build's env-vars file, nor can I find any documentation about the flag being added by anything in stdenv.mkDerivation. Anybody know where that flag is coming from?

Note: In io.js 1.8.1, a --enable-static flag was added via this PR.

@lucabrunox
Copy link
Contributor

It's added by the stdenv. You can override the configurePhase.

@Havvy
Copy link
Contributor Author

Havvy commented May 19, 2015

Didn't need to override configrePhase since I found an undocumented switch (and documented it), but it was still failing, and I've giving up. I've filed #7907 if anybody else wants to tackle this.

@Havvy Havvy closed this May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants