Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android-studio: add missing emulator dependency #75925

Merged
merged 1 commit into from
Dec 22, 2019
Merged

android-studio: add missing emulator dependency #75925

merged 1 commit into from
Dec 22, 2019

Conversation

alapshin
Copy link
Contributor

Motivation for this change

New versions of android emulator require libuuid which is missing from current FHS environment
Similar to recent PR #70857

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @primeos

@ofborg ofborg bot requested a review from primeos December 19, 2019 08:05
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Dec 19, 2019
jonringer
jonringer approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launched fine, ate up a lot of ram

[13 built, 36 copied (2354.4 MiB), 2333.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75925
4 package were built:
android-studio androidStudioPackages.beta androidStudioPackages.canary androidStudioPackages.dev

primeos
primeos approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff LGTM, but unfortunately I don't have a test setup for the emulator atm.

This should also fix #75381.

@jonringer did you also test the emulator?

@primeos primeos merged commit 7d42107 into NixOS:master Dec 22, 2019
@primeos primeos mentioned this pull request Dec 22, 2019
Closed
@jonringer
Copy link
Contributor

I did not, but libuuid seems like something that would likely be needed

@alapshin alapshin deleted the feature/android-studio-emulator-deps branch April 9, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alapshin @jonringer @primeos