Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run: init at 0.7.0 #77081

Merged
merged 1 commit into from
Jan 11, 2020
Merged

run: init at 0.7.0 #77081

merged 1 commit into from
Jan 11, 2020

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Jan 6, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Br1ght0ne
Br1ght0ne requested changes Jan 6, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the hash mismatch, LGTM

pkgs/development/tools/run/default.nix Outdated Show resolved Hide resolved
Br1ght0ne
Br1ght0ne approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

https://github.com/NixOS/nixpkgs/pull/77081
1 package built:
run

markuskowa
markuskowa reviewed Jan 6, 2020
View reviewed changes
pkgs/development/tools/run/default.nix

meta = with stdenv.lib; {
description = "Easily manage and invoke small scripts and wrappers";
homepage = https://github.com/TekWizely/run;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://github.com/TekWizely/run;
homepage = "https://github.com/TekWizely/run";

@markuskowa
Copy link
Member

@GrahamcOfBorg build run

misuzu
misuzu approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on macOS.

@ofborg ofborg bot requested a review from kalbasit January 6, 2020 20:53
@nlewo nlewo merged commit 99470a3 into NixOS:master Jan 11, 2020
@TekWizely
Copy link

TekWizely commented Jul 3, 2022 •
edited
Loading

TIL my Run project has had a nixpkg for over 2.5 years !

I would have loved a CC on this PR back then, as I would have updated the Installation section of my Readme to include this package.

I will be adding that now that I know it exists.

Q: Is there any way to get statistics on the installation / search count for the package?

Q: Is there an official channel for submitting updates? Looks like the package has been updated to 0.7.2 but I've had a couple of releases since (and a new one coming).

Thanks for taking the time to make my project into a package - I'm really stoked to see it being accessible to more users!

-TW
[edit: typos/spelling/grammar]

cc: @rawkode

@nlewo
Copy link
Member

nlewo commented Jul 3, 2022 •
edited
Loading

Q: Is there any way to get statistics on the installation / search count for the package?

We don't have any installation statistics. Moreoever, i don't think the search.nixos.org website exposes stats.

Q: Is there an official channel for submitting updates?

Here ;)
To contribute to nixpkgs (update a package for instance), we submit PR, such as the current one. You could find more details in the nixpkgs manual: https://nixos.org/manual/nixpkgs/stable/#submitting-changes-making-patches

This was referenced Jul 3, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

@misuzu misuzu misuzu approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rawkode @markuskowa @TekWizely @nlewo @misuzu @Br1ght0ne