Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run: init at 0.7.0 #77081

Merged
merged 1 commit into from Jan 11, 2020
Merged

run: init at 0.7.0 #77081

merged 1 commit into from Jan 11, 2020

Conversation

@rawkode
Copy link
Member

@rawkode rawkode commented Jan 6, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

Besides the hash mismatch, LGTM

pkgs/development/tools/run/default.nix Outdated Show resolved Hide resolved
@rawkode rawkode force-pushed the rawkode:feature/add-run branch from 470bd7e to 22622e9 Jan 6, 2020
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

https://github.com/NixOS/nixpkgs/pull/77081
1 package built:
run

meta = with stdenv.lib; {
description = "Easily manage and invoke small scripts and wrappers";
homepage = https://github.com/TekWizely/run;

This comment has been minimized.

@markuskowa

markuskowa Jan 6, 2020
Member

Suggested change
homepage = https://github.com/TekWizely/run;
homepage = "https://github.com/TekWizely/run";
@markuskowa
Copy link
Member

@markuskowa markuskowa commented Jan 6, 2020

@GrahamcOfBorg build run

@misuzu
misuzu approved these changes Jan 6, 2020
Copy link
Contributor

@misuzu misuzu left a comment

Builds on macOS.

@ofborg ofborg bot requested a review from kalbasit Jan 6, 2020
@nlewo nlewo merged commit 99470a3 into NixOS:master Jan 11, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
run on aarch64-linux Success
Details
run on x86_64-darwin Success
Details
run on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.