nixos/factorio: add extraSettings and package options #77478
Conversation
Currently there is no way to set game settings, such as administrators. extraSettings allows users to override default game settings without adding many more settings. The package option allows users to use the experimental version, or override to a specific version with their own modified package.
ofborg
bot
added
6.topic: nixos
| @@ -37,7 +36,7 @@ let | |||
| only_admins_can_pause_the_game = true; | |||
| autosave_only_on_server = true; | |||
| admins = []; | |||
| }; | |||
| } // cfg.extraSettings; | |||
There was a problem hiding this comment.
instead of adding an option to override all of the other configuration, why don't you extend the current options to include admins and others.
Also, you should probably be using something like mkMerge to ensure that the keys are gracefully composed.
There was a problem hiding this comment.
Extending the current options seems like a good idea. I didn't want to bloat the options too much, but that would definately help with documentation. I'll update this PR and add an option for admins.
There was a problem hiding this comment.
I wanted to create a factorio server with services.factorio and everything worked straight away. However, I can't make myself an admin, not even when I delete the state directory and restart the service with extraConfig = { admins = [ "username" ] } in place. Is extraConfig currently broken or am I doing something wrong? As far as I see it's generally not possible to connect a TTY to the server and run /promote <username>.
There was a problem hiding this comment.
I had this issue as well, I'll look into it. But probably not til after the 20.09 release
There was a problem hiding this comment.
that being said, do you mind making an issue on github? better way to track than a comment, and please cc me
Motivation for this change
Currently there is no way to set game settings, such as administrators, other than those specified. There is also no way to use the experimental version.
Things done
The package option allows users to use the experimental version, or
override to a specific version with their own modified package.
extraSettings allows users to override default game settings without
adding many more settings.
I also tested this change and successfully ran a factorio server based on this.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)