Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fastdtw: init at 0.3.4 #78868

Merged
merged 1 commit into from
Feb 25, 2020
Merged

pythonPackages.fastdtw: init at 0.3.4 #78868

merged 1 commit into from
Feb 25, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Add dependency for upcoming qiskit-terra package #78772 @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger drewrisinger changed the title Dr pr python fastdtw pythonPackages.fastdtw: init at 0.3.4 Jan 30, 2020
@drewrisinger
Copy link
Contributor Author

Tried running tests w/ GitHub checkout & pytest, but it has trouble finding the cython-ized code.

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.fastdtw

@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 30, 2020
@drewrisinger drewrisinger mentioned this pull request Feb 24, 2020
Open
@drewrisinger drewrisinger force-pushed the dr-pr-python-fastdtw branch 2 times, most recently from 80fe458 to bccaf47 Compare February 24, 2020 15:50
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.fastdtw python38Packages.fastdtw

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg eval

@drewrisinger
pythonPackages.fastdtw: init at 0.3.4
de02a7f 
Fast implementation of Dynamic Time Warping algorithm.

Dependency for qiskit-aqua.
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.fastdtw python38Packages.fastdtw
@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.fastdtw python38Packages.fastdtw

@jonringer jonringer merged commit ee3226b into NixOS:master Feb 25, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-fastdtw branch February 25, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewrisinger @jonringer