Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "gitAndTools.gh: fix build on darwin" #83632

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Revert "gitAndTools.gh: fix build on darwin" #83632

merged 1 commit into from
Mar 29, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Mar 28, 2020

This reverts commit a51275f.

Not needed now that Security is propagated via go in 0bba747

cc @marsam

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Revert "gitAndTools.gh: fix build on darwin"
2ae5cf3 
This reverts commit a51275f.

Not needed now that Security is propagated via go in 0bba747
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 28, 2020
@ofborg ofborg bot requested a review from kalbasit March 29, 2020 00:02
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Mar 29, 2020
@veprbl veprbl requested a review from marsam March 29, 2020 01:56
@Mic92 Mic92 merged commit 30c17b6 into NixOS:master Mar 29, 2020
@zowoq zowoq deleted the gh-darwin branch March 29, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zowoq @Mic92