Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/display-managers: don't start pulseaudio #83717

Merged
merged 1 commit into from
Apr 1, 2020
Merged

nixos/display-managers: don't start pulseaudio #83717

merged 1 commit into from
Apr 1, 2020

Conversation

worldofpeace
Copy link
Contributor

Hey, we have sockets.

Motivation for this change

@jtojnar and I believe this shouldn't be needed anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Mar 29, 2020
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Apr 1, 2020 •
edited
Loading

I have used this with GNOME and Pantheon for the past two days without issue.

@jtojnar
Copy link
Member

jtojnar commented Apr 1, 2020

LGTM then.

@worldofpeace worldofpeace merged commit 252ca37 into NixOS:master Apr 1, 2020
@worldofpeace worldofpeace deleted the drop-pulseaudio-cruft-display-manager branch April 1, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worldofpeace @jtojnar