-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zrythm: init at 0.8.252 #85553
zrythm: init at 0.8.252 #85553
Conversation
|
@jtojnar Thanks for the feedback, all done! Then we only need a solution for the dconf issue and this pkg is good to go! |
Also it should be done in |
@jtojnar Thanks for the review. |
@magnetophon Is this PR still WIP as concluded from the title? |
I think it's good now, apart from the meanwhile outdated version. |
@magnetophon Please drop WIP from the title and ping a reviewer again. This PR might have been overlooked due to WIP in the title. |
@0x4A6F Thanks. |
any update on this? |
It would be great to merge this PR @magnetophon and @jtojnar. |
It cannot be merged while it has merge conflicts. |
Is there a way for me to help directly on this PR or is it necessary for example to make another PR if I want to help fixing the merge conflicts @SuperSandro2000? |
You could do that if you like. |
I resolved the conflicts and updated the zrythm version on felix-andreas@38185e8 Maybe this can be merged into this PR or should I open a new PR? |
Please open a new PR. That is easier and makes the git history cleaner. |
@andreasfelix would it be possible for you to make a PR for your branch, it looks really awesome! |
This PR can be closed now that #144547 has been merged. |
Problem description:
When I try to install this with:
nix-env -f $NIXPKGS -iA zrythm
I get:When I do:
it builds.
I can then successfully run it with
/nix/store/nkyh59931zydxb80j3j5i1whcva6ijbl-zrythm-0.8.252/bin/zrythm_launch
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)