Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpython: substituteAll the path to which #89439

Merged
merged 1 commit into from
Jun 15, 2020
Merged

bpython: substituteAll the path to which #89439

merged 1 commit into from
Jun 15, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 3, 2020

This is used to detect the presence of xclip and other clipboard
handling tools.

Tested by actually copying something to the clipboard :-)

Motivation for this change

Fixes #56941.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @memberbetty

@flokli
bpython: substituteAll the path to which
7de3d93 
This is used to detect the presence of xclip and other clipboard
handling tools.

Fixes NixOS#56941.
@flokli flokli requested a review from dotlambda June 3, 2020 20:13
@flokli flokli mentioned this pull request Jun 3, 2020
Closed
@ofborg ofborg bot added 6.topic: python 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 3, 2020
@flokli flokli merged commit 8257210 into NixOS:master Jun 15, 2020
@flokli flokli deleted the bpython-xclip branch June 15, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bpython depends on which
1 participant
@flokli