-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python2Packages.nixpart0: fix build #89948
Conversation
@GrahamcOfBorg build python2Packages.nixpart0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One request:
Please put a comment on each patch / fetchpatch
that says why we need it (ideally also linking to the issue where we found the bug).
Beyond that, I have already tested this on 20.03.
7211023
to
05f1bcc
Compare
Thanks! I added a brief note to each patch (mirroring the commit message) with a link to the issue as well. Let me know if that looks good or if there's anything else you would like me to amend. |
@pbogdan: Thanks a lot, building and merging in a moment. |
Motivation for this change
While AFAICT not used directly in nixpkgs the package is used for provisioning new servers in nixops' Hetzner module.
This PR contains a collection of fixes for the package's dependencies to unblock its build. Closes #86403.
This branch contains the same commits as in #86403 (comment) just rebased onto more recent master.
If accepted I will make a backport PR to 20.03 as well as per the discussion on the linked issue.
/cc @nh2
/cc @kolloch @mkg20001 who might still be interested as well
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)