fedora-coreos-config-transpiler: init at 0.6.0 #91057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
flokli
reviewed
Jun 18, 2020
| description = "Translates Fedora CoreOS configs into Ignition configs"; | ||
| license = licenses.asl20; | ||
| homepage = "https://github.com/coreos/fcct"; | ||
| maintainers = with maintainers; [elijahcaine ruuda]; |
There was a problem hiding this comment.
Suggested change
| maintainers = with maintainers; [elijahcaine ruuda]; | |
| maintainers = with maintainers; [ elijahcaine ruuda ]; |
| license = licenses.asl20; | ||
| homepage = "https://github.com/coreos/fcct"; | ||
| maintainers = with maintainers; [elijahcaine ruuda]; | ||
| platforms = with platforms; unix; |
There was a problem hiding this comment.
Suggested change
| platforms = with platforms; unix; | |
| platforms = platforms.unix; |
pkgs/development/tools/fedora-coreos-config-transpiler/default.nix
Outdated
Show resolved
Hide resolved
Fedora CoreOS Config Transpiler (FCCT) is to Fedora CoreOS what Container Linux Config Transpiler (CT) was to CoreOS Container Linux.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We package the CoreOS Container Linux Config Transpiler, but CoreOS Container Linux has reached end of life, and has been superseded by Fedora CoreOS. The Fedora CoreOS Config Transpiler (FCCT) is the equivalent config transpiler for Fedora CoreOS.
I am not removing the original Container Linux Config Transpiler, because Container Linux lives on in Flatcar Linux.
The new package is a copy of the container-linux-config-transpiler package, with metadata updated and
postInstallslightly simplified.@pop I added you as a maintainer because you are the maintainer of the original config transpiler package, are you okay with that?
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)