Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pkgsCross.*.texinfoInteractive #92794

Merged
merged 2 commits into from
Jul 10, 2020
Merged

fix pkgsCross.*.texinfoInteractive #92794

merged 2 commits into from
Jul 10, 2020

Conversation

dguibert
Copy link
Member

@dguibert dguibert commented Jul 9, 2020 •
edited
Loading

This fixes #86166 to build cross compilied texinfoInteractive.
BUILD_CC has been renamed to CC_FOR_BUILD so the patch needs to applied
this renaming.

tested on: pkgsCross.armv7l-hf-multiplatform.texinfoInteractive

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dguibert
fix pkgsCross.*.texinfoInteractive
a2eb391 
This fixes NixOS#86166 to build cross compilied texinfoInteractive.
BUILD_CC has been renamed to CC_FOR_BUILD so the patch needs to applied
this renaming.

tested on: pkgsCross.armv7l-hf-multiplatform.texinfoInteractive
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 9, 2020
@Ericson2314
Copy link
Member

Ericson2314 commented Jul 10, 2020 •
edited
Loading

~~The diff is very weird looking?~ I think you have an unintentional extra space?

Oh I understand now---I messed it up in my commit. Sorry about that. But let's do take away that stray space.

@dguibert
Copy link
Member Author

~~The diff is very weird looking?~ I think you have an unintentional extra space?

Oh I understand now---I messed it up in my commit. Sorry about that. But let's do take away that stray space.

The extra space has been removed.

@Mic92 Mic92 merged commit 33b5621 into NixOS:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dguibert @Ericson2314 @Mic92