-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openexr, ilmbase: Fix compilation on non-glibc. #94205
Conversation
* include workaround for NixOS/nixpkgs#85924 * musl 1.2.0 (#98 (comment)) * workaround for fontforge execution failure due to wrong RPATH (NixOS/nixpkgs#94126) * ilmbase musl compilation error (NixOS/nixpkgs#94205) * mesa: Fix `-Werror=int-conversion` build error on musl fixup! nixpkgs: Update submodule:
* include workaround for NixOS/nixpkgs#85924 * musl 1.2.0 (#98 (comment)) * workaround for fontforge execution failure due to wrong RPATH (NixOS/nixpkgs#94126) * ilmbase musl compilation error (NixOS/nixpkgs#94205) * mesa: Fix `-Werror=int-conversion` build error on musl (NixOS/nixpkgs#94207)
Tested with musl. I PRd the patch upstream: AcademySoftwareFoundation/openexr#798
66b9031
to
d939373
Compare
Updated to avoid rebuild on Darwin. |
non_glibc_fpstate_patch = | ||
# Fix ilmbase/openexr using glibc-only fpstate. | ||
# Found via https://git.alpinelinux.org/aports/tree/community/openexr/10-musl-_fpstate.patch?id=80d9611b7b8e406a554c6f511137e03ff26acbae, | ||
# TODO Remove when https://github.com/AcademySoftwareFoundation/openexr/pull/798 is merged and available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be merged now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not available
though (no release made).
Merging as this has 0-rebuilds and it fixes musl builds. |
* include fixes for GHC segfaulting: (NixOS/nixpkgs#129247, NixOS/nixpkgs#129289) * musl 1.2.2, including this important fix from musl 1.2.0: #98 (comment) * workaround for fontforge execution failure due to wrong RPATH: NixOS/nixpkgs#94126 * ilmbase musl compilation error: NixOS/nixpkgs#94205 * mesa: Fix `-Werror=int-conversion` build error on musl: NixOS/nixpkgs#94207
* include fixes for GHC segfaulting: (NixOS/nixpkgs#129247, NixOS/nixpkgs#129289) * musl 1.2.2, including this important fix from musl 1.2.0: #98 (comment) * workaround for fontforge execution failure due to wrong RPATH: NixOS/nixpkgs#94126 * ilmbase musl compilation error: NixOS/nixpkgs#94205 * mesa: Fix `-Werror=int-conversion` build error on musl: NixOS/nixpkgs#94207 survey: * Update file in which stackage packages are listed. See nixpkgs commit 7f236bd4 - hackage2nix: Split configuration, auto disable hydra builds
* include fixes for GHC segfaulting: (NixOS/nixpkgs#129247, NixOS/nixpkgs#129289) * musl 1.2.2, including this important fix from musl 1.2.0: #98 (comment) * workaround for fontforge execution failure due to wrong RPATH: NixOS/nixpkgs#94126 * ilmbase musl compilation error: NixOS/nixpkgs#94205 * mesa: Fix `-Werror=int-conversion` build error on musl: NixOS/nixpkgs#94207 survey: * Update file in which stackage packages are listed. See nixpkgs commit 7f236bd4 - hackage2nix: Split configuration, auto disable hydra builds
Motivation for this change
musl compatibility via nh2/static-haskell-nix#98.
Tested with musl.
I PRd the patch upstream: AcademySoftwareFoundation/openexr#798
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)