Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependabot: automatically update github actions #94285

Merged
merged 1 commit into from
Jul 31, 2020
Merged

dependabot: automatically update github actions #94285

merged 1 commit into from
Jul 31, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 31, 2020 •
edited
Loading

No description provided.

@Mic92
Copy link
Member Author

Mic92 commented Jul 31, 2020

cc @zowoq

same as in NixOS/nix#3757

zowoq
zowoq approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mic92 Mic92 merged commit af652dd into NixOS:master Jul 31, 2020
@Mic92 Mic92 deleted the dependabot branch July 31, 2020 05:11
@ofborg ofborg bot added 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 31, 2020
@lopsided98
Copy link
Contributor

Unfortunately, it seems that this runs on forks as well. It appears that if the master branch of your fork contains this commit, your fork starts getting dependabot PRs, and I can't find a way to turn it off.

@lopsided98
Copy link
Contributor

The documentation claims that it has to be manually enabled: https://docs.github.com/en/github/administering-a-repository/enabling-and-disabling-version-updates#enabling-version-updates-on-forks

I'm certain I never manually enabled it, but it seems to be enabled anyway and there doesn't seem to be any way to disable it.

@zowoq
Copy link
Contributor

zowoq commented Aug 10, 2020

@Mic92 We may want to disable this until we can restrict it to this repo so it isn't spamming forks.

cc @Ma27

@zowoq
Copy link
Contributor

zowoq commented Aug 10, 2020 •
edited
Loading

Upstream has an open issue about this: dependabot/dependabot-core#2198 (comment)

Dependabot is disabled by default for forks ... but sometimes it starts sending PRs anyway.

NixOS/nixpkgs-channels#23

It's even opened a PR in the channel mirror.

@zowoq zowoq mentioned this pull request Aug 10, 2020
Merged
@zowoq
Copy link
Contributor

zowoq commented Aug 10, 2020

#95055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq approved these changes

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mic92 @lopsided98 @zowoq