nixos/update-user-groups: Fix encoding issues + atomic writes #98544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we would treat everything as bytes however our database is already utf-8 encoded so we need to stay compatible.
The issue here is that updateFile expects a unicode string while encode_json returns a binary string unlike to_json.
Having the .tmp suffix is broken w.r.t. to multiple writers, as they would overwrite existing files. using the atomic flag will make write_file to create a unique temporary file it gets renamed to its target.
This was referenced Sep 23, 2020
Mic92
commented
Sep 23, 2020
| updateFile($uidMapFile, encode_json($uidMap)); | ||
| updateFile($uidMapFile, to_json($uidMap)); | ||
| updateFile("/etc/passwd", \@lines); | ||
| system("nscd --invalidate passwd"); |
There was a problem hiding this comment.
Note that this still gets inconsistent when multiple writers update multiple files in different order.
stigtsp
reviewed
Sep 23, 2020
jonringer
approved these changes
Sep 23, 2020
jonringer
added
the
9.needs: port to stable
|
lgtm and I had a friendly perlmonger review it, so going to go ahead and merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)