Composer formatting options should no longer be hardcoded in core

[julianlam]

We hard-code bold, italic, etc in core, but the real awkward part is that the parser is a plugin, meaning if you swapped out Markdown for something else (like BBCode), you would still get the old formatting options inputting markdown into the composer instead of [b], etc.

Oops.

Additionally, several other plugins attempt to modify the toolbar, but because of this hardcoding, plugins are resorting to tactics like appending to the end, which is good, but not powerful enough.

• Add a filter for plugins to add their own formatting options
• Update Markdown plugin to utilise this method
• Remove hardcoded formatting options from core

[MegaGM]

I guess this discussion is related #2654

[julianlam]

Yep, sure is. I incorporated most of the changes outlined in that issue, so we can build off of the changes introduced here.

[julianlam]

@psychobunny @TedRinehart @a5mith I believe you all append buttons to the toolbar in some way?

You can see how Markdown does it here

[MegaGM]

Thank you! These changes were necessary, definitely.
Next step will be using composer in plugins :3 I've planned it for nodebb-plugin-mega-chatbox

[julianlam]

Please let us know if you run into any awkward issues with the composer when integrating with another plugin.

For example, the composer itself should be a distinct entity from other parts of NodeBB, so if you catch it doing weird things like posting new topics, etc, let us know.

[MegaGM]

so if you catch it doing weird things like posting new topics, etc, let us know.

@julianlam Of course 👍