Ref #3250 Fixes #3251: split repository in ro/rw #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/agpl.html>. | |||
| <parent> | |||
| <groupId>com.normation</groupId> | |||
| <artifactId>parent-pom</artifactId> | |||
| <version>2.6.0-SNAPSHOT</version> | |||
| <version>2.6.0-scala_2.10-SNAPSHOT</version> | |||
There was a problem hiding this comment.
The pom version should not change, a rebase on should fix that
There was a problem hiding this comment.
Yes, clearly, well spotted. I though I changed all of them.
|
Don't you think that objects named "roXXXrepository" or "woXXXrepository" should be name "xxxReader" or "xxxWriter" ? |
|
The same questions about the classes "WoXXXRepository" and "RoXXXRepository" being renamed to "XXXWriter" "XXXReader" |
|
|
||
| } | ||
|
|
||
| class RwLDAPDirectiveRepository( |
There was a problem hiding this comment.
Shouldn't it be WoLDAPDirectiveRepository ?
|
Appart from the TW/RO, this is really nice ! I let you answer on or correct the names of the repos |
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.