Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] [MIG] contract #121

Merged
merged 33 commits into from
Nov 19, 2017
Merged

[11.0] [MIG] contract #121

merged 33 commits into from
Nov 19, 2017

Conversation

feketemihai
Copy link
Member

@pedrobaeza I made e new PR, since i had issues when fetching all commits from previous repo...

@pedrobaeza
Copy link
Member

@feketemihai I have reduced the number of commits merging "OCA Transbot..." ones following https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests and others from same author that were split in the merge process (not squashing them on the PR). This way, we reduce a lot the size of the repo avoiding useless diffs.

Finally, I have included last change that I have merged today: 7ec82c7

@feketemihai
Copy link
Member Author

@pedrobaeza sorry about transifex commits, i focused a lot in the Hr and Romania branch and totally forgot about this Pr... Thanks

cubells and others added 9 commits November 19, 2017 05:54
* [IMP][9.0] contract: Add report + send by mail

* Update translation and rename contract report

* Changes requested and translation updated
Update contract template lines handling to fix OCA#80, and fix OCA#59 OCA#100
Having a primary view that is not explicitly declared to be uses and w/o priority
makes Odoo to choose between one of them randomly (well, not exactly, but kind of),
so we put here which views to use.

I have also put tree view as primary and put a large priority for not being
selected on other actions that don't have this explicit views.

A friendly name in views is also assigned.
* Use SavepointCase for making the setup only once for all tests
* Make them inheritable, creating a base class with only the setup,
  so that it can be inherited without the need of executing all tests
  contained here each time you inherit it, and adding other class
  in the same module that inherits from the base class that actually
  performs the tests.
* Removed duplicated test method
@pedrobaeza
Copy link
Member

No problem. Merging.

@pedrobaeza pedrobaeza merged commit fe7e87c into OCA:11.0 Nov 19, 2017
@pedrobaeza pedrobaeza mentioned this pull request Nov 19, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants