[12.0][MIG] - Migration module contract to 12.0 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbejaoui
changed the title
sbejaoui
changed the title
sbejaoui
force-pushed
the
12.0-mig-contract
branch
from
5ff9c03
to
d9b3f51
Compare
sbejaoui
changed the title
pedrobaeza
requested changes
Oct 25, 2018
There was a problem hiding this comment.
Welcome to OCA and congratulations for your PRs! They are very well. Just a little suggestion and other warnings in runbot that remarks some problems:
2018-10-25 15:01:38,243 153 WARNING openerp_test odoo.models: The model account.analytic.contract has no _description
2018-10-25 15:01:38,992 153 WARNING openerp_test odoo.addons.base.models.ir_ui_view: The group sale.group_discount_per_so_line defined in view Contract form does not exist!
2018-10-25 15:01:39,058 153 WARNING openerp_test odoo.addons.base.models.ir_ui_view: The group sale.group_discount_per_so_line defined in view account.analytic.account.sale.form does not exist!
2018-10-25 15:01:39,108 153 WARNING openerp_test odoo.addons.base.models.ir_ui_view: The group sale.group_discount_per_so_line defined in view account.analytic.account.purchase.form does not exist!
2018-10-25 15:01:39,253 153 WARNING openerp_test odoo.addons.base.models.ir_ui_view: The group sale.group_discount_per_so_line defined in view Account Analytic Contract Form View does not exist!
This was referenced Oct 25, 2018
|
I think you haven't pushed your changes here. |
|
Hi @pedrobaeza, The warning is raised due to the use of I think, we should use the |
sbejaoui
force-pushed
the
12.0-mig-contract
branch
from
d9b3f51
to
a17a89b
Compare
OK, Odoo does that with discount field in invoices |
sbejaoui
force-pushed
the
12.0-mig-contract
branch
from
aa3ed5c
to
b3e2931
Compare
* Translations * Access rules * README * Currency for created invoices. * #START# and #END# set correctly * Some conventions
…company environment Now when working on multy company environmets the server action creates invioices with accounts belong to correct company based on contract company.
* Tests added * Filters added. * Add _id/_ids in old property fields * Translations
Add template functionality for contracts
If you have contract lines with automatic price and your pricelist contains different prices per quantity, the price is not changed when computing quantity. This PR fixes this.
Bug description --------------- `account.analytic.contract.line` inherits `account.analytic.invoice.line` `account.analytic.invoice.line` defines field `analytic_account_id`: - comodel='account.analytic.account' `account.analytic.contract.line` redefines field `analytic_account_id`: - comodel='account.analytic.contract' On attempt to extend `account.analytic.invoice.line` model adding field that depends on `analytic_account_id.date_start` Odoo fails to update, because it adds this field to `account.analytic.contract.line` through inheritance, and `account.analytic.contract` model have no this field. What is done ------------ Change inheritance order: - `account.analytic.invoice.line` inherits `account.analytic.contract.line` - no file renames at this stage (this wil be done in next commit)
In previous commit changed inheritance order of 'account.analytic.*.line' models, thus classes and models were renamed. This commit only renames files to temporary names. This commit does not change file contents.
Runbot URL in old README.rst pointed to 10.0 runbot, fixed by upgrading template
Currently translated at 96.0% (96 of 100 strings) Translation: contract-11.0/contract-11.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract/nl/
Currently translated at 53.0% (53 of 100 strings) Translation: contract-11.0/contract-11.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract/de/
Currently translated at 75.0% (75 of 100 strings) Translation: contract-11.0/contract-11.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract/de/
Currently translated at 98.0% (98 of 100 strings) Translation: contract-11.0/contract-11.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract/es/
Currently translated at 10.0% (10 of 100 strings) Translation: contract-11.0/contract-11.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract/pt_PT/
The test as it was, leaves to the demo pricelist the control on the price of the product, so other modules that modifies this pricelist will make the test to fail. This is the minimum change needed for avoiding the problem.
- Module: contract
- Summary: several terms where not translated to Spanish.
pedrobaeza
force-pushed
the
12.0-mig-contract
branch
from
b3e2931
to
12ac4e1
Compare
pedrobaeza
approved these changes
Oct 27, 2018
sbidoul
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.