[13.0][MIG] base_location: Migration to 13.0 #785

pedrobaeza · 2019-09-30T14:05:47Z

cc @Tecnativa TT19707

… when company country is filled.

…tter-zip field

…ssues with module partner_address_street3

…some views. Added two columns in respective tree views.

…ooks * Added Icon. * Improve module description and extracted to README.rst. * Pass country instead of country_id for advance comparisons. * Allow to transform city name. * Some code style. * Do not remove all entries of a country, but only not found. * Include hooks for transforming some things. * Include spanish translation.

Brussels Belgium city

…y, state and country in order to allow search using '%' from the m2o widget

* Headers shortened * Move cities management to settings

… state view

* [IMP] base_location: Add lat & long to `better.zip` * Add latitude and longitude columns to `better.zip` * [IMP] base_location_geonames_import: Add lat/long * Add support for latitude & longitude to genomes importer

Incredibly not included in Odoo core.

Currently translated at 66.7% (24 of 36 strings) Translation: partner-contact-11.0/partner-contact-11.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_location/es/

Currently translated at 100,0% (36 of 36 strings) Translation: partner-contact-11.0/partner-contact-11.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_location/de/

This module has now been refactored to be more consistent with what base_address_city offers to the location management. Added dependency to contacts so that I could change the menu location for cities / zip management. Now, every res.city record has a relation One2many to res.city.zip (old res.better.zip). This way, every zip has a realted city too. Zips can be searched through city code, zip or city name (same as before). Modified tests and deleted not needed tests. Added sql contraints so that zips and cities are unique within it's country / state / city.

Steps: - Open company form - Set 'city completion' field Get 'The state of the partner My Company differs from that in location X' Disabling _check_zip while writing 'zip' fields from company, as incompatible with the sequence of write operations. Automatic test is added too.

Currently translated at 57.6% (19 of 33 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_location/es/

Previous script required to have cities populated for working, but that's not usual thing, as people in v11 may choose to not import them, and for older databases they even weren't that option. With this improve script, now we populate city table for ZIP entries without city, so the rest of the queries are properly executed in any case.

pedrobaeza · 2019-10-01T21:44:06Z

/ocabot merge

OCA-git-bot · 2019-10-01T21:44:25Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-785-by-pedrobaeza-bump-no, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2019-10-02T01:23:09Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-785-by-pedrobaeza-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2019-10-03T10:03:16Z

/ocabot merge

OCA-git-bot · 2019-10-03T10:03:31Z

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-785-by-pedrobaeza-bump-no, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2019-10-03T10:54:42Z

@pedrobaeza The merge process could not be finalized, because command setuptools-odoo-make-default --addons-dir . --metapackage oca-partner-contact --clean --commit failed with output:

Traceback (most recent call last):
  File "/usr/local/bin/setuptools-odoo-make-default", line 11, in <module>
    sys.exit(main())
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/make_default_setup.py", line 391, in main
    args.addons_dir, args.force, args.odoo_version_override)
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/make_default_setup.py", line 152, in make_default_setup_addons_dir
    odoo_version_override)
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/make_default_setup.py", line 102, in make_default_setup_addon
    git_post_version=False)
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/core.py", line 116, in _get_version
    (odoo_version, addon_dir))
distutils.errors.DistutilsSetupError: Unsupported odoo version '13.0' in ./partner_fax

pedrobaeza · 2019-10-03T11:38:11Z

@moylop260 why 13.0 is not admitted in pylint-odoo yet? I thought OCA/pylint-odoo#249 was for that.

moylop260 · 2019-10-03T22:21:24Z

pylint is supporting 13.0

The lint travis build is green
https://travis-ci.org/OCA/partner-contact/jobs/591521616

I think it is another tool

pedrobaeza · 2019-10-04T05:25:19Z

/ocabot merge

OCA-git-bot · 2019-10-04T05:49:56Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-785-by-pedrobaeza-bump-no, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2019-10-04T06:09:05Z

@pedrobaeza The merge process could not be finalized, because command setuptools-odoo-make-default --addons-dir . --metapackage oca-partner-contact --clean --commit failed with output:

Traceback (most recent call last):
  File "/usr/local/bin/setuptools-odoo-make-default", line 11, in <module>
    sys.exit(main())
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/make_default_setup.py", line 391, in main
    args.addons_dir, args.force, args.odoo_version_override)
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/make_default_setup.py", line 152, in make_default_setup_addons_dir
    odoo_version_override)
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/make_default_setup.py", line 102, in make_default_setup_addon
    git_post_version=False)
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/core.py", line 116, in _get_version
    (odoo_version, addon_dir))
distutils.errors.DistutilsSetupError: Unsupported odoo version '13.0' in ./partner_fax

rousseldenis · 2019-10-04T07:31:28Z

@pedrobaeza @sbidoul is looking into this now

pedrobaeza · 2019-10-04T07:34:13Z

Great, thanks

sbidoul · 2019-10-04T08:07:04Z

/ocabot merge

OCA-git-bot · 2019-10-04T08:07:15Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-785-by-sbidoul-bump-no, awaiting test results.

Signed-off-by sbidoul

pedrobaeza · 2019-10-04T08:19:20Z

@sbidoul I created https://odoo-community.org/web#id=847934&action=468&active_id=2&model=project.task&view_type=form&menu_id=748 for all the things to do on a new version, so if there's something for the bot, please indicate it there

sbidoul · 2019-10-04T08:23:09Z

@pedrobaeza thanks for the initiative. Updated.

OCA-git-bot · 2019-10-04T08:25:39Z

@sbidoul The merge process could not be finalized, because command setuptools-odoo-make-default --addons-dir . --metapackage oca-partner-contact --clean --commit failed with output:

Traceback (most recent call last):
  File "/usr/local/bin/setuptools-odoo-make-default", line 11, in <module>
    sys.exit(main())
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/make_default_setup.py", line 391, in main
    args.addons_dir, args.force, args.odoo_version_override)
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/make_default_setup.py", line 152, in make_default_setup_addons_dir
    odoo_version_override)
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/make_default_setup.py", line 102, in make_default_setup_addon
    git_post_version=False)
  File "/ocamt/lib/python3.6/site-packages/setuptools_odoo/core.py", line 116, in _get_version
    (odoo_version, addon_dir))
distutils.errors.DistutilsSetupError: Unsupported odoo version '13.0' in ./partner_fax

sbidoul · 2019-10-04T09:11:08Z

/ocabot merge

OCA-git-bot · 2019-10-04T09:11:25Z

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-785-by-sbidoul-bump-no, awaiting test results.

Signed-off-by sbidoul

OCA-git-bot · 2019-10-04T09:46:46Z

Congratulations, your PR was merged at e29c9a2. Thanks a lot for contributing to OCA. ❤️

nbessi and others added 14 commits September 30, 2019 11:50

[MV] rename better_zip to base_location

31b1401

base_location: [IMP] Spanish translation and translation template.

0a1e9e6

[FIX] mutable default in function signature

c58a356

[FIX] base_location: Changed partner view to avoid extrange behaviour…

dacf3f5

… when company country is filled.

[FIX] Add context propagation to base_location

7b9c78b

[Add] Add italian translation, change field class to edit-only for be…

59c03a7

…tter-zip field

base_location: Don't position zip_id after street2, to avoid layout i…

6685ccb

…ssues with module partner_address_street3

Danish translation

ff08a58

[IMP] base_location: Updated to v8 syntax and uses. Added filters in …

bfbd973

…some views. Added two columns in respective tree views.

Add demo data

dcaa5e6

Brussels Belgium city

IMP Create new computed stored field 'display_name' that use zip, cit…

7cf35b4

…y, state and country in order to allow search using '%' from the m2o widget

Translated to Danish

1ec32f4

[MIG] base_location: Migration to 9.0

61b11b8

pedrobaeza added this to the 13.0 milestone Sep 30, 2019

OpenCode and others added 15 commits September 30, 2019 16:10

[MIG] base_location: Migrated to 10.0

b24c1d6

* Headers shortened * Move cities management to settings

[FIX][10.0] base_location : "better_zip_ids" field set colspan="2" in…

cee448d

… state view

[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)

e96e899

* [IMP] base_location: Add lat & long to `better.zip` * Add latitude and longitude columns to `better.zip` * [IMP] base_location_geonames_import: Add lat/long * Add support for latitude & longitude to genomes importer

OCA Transbot updated translations from Transifex

115198e

[MIG] base_location

ff21c09

OCA Transbot updated translations from Transifex

07ea1b4

[IMP] base_location: Include onchange for state

76e77c0

Incredibly not included in Odoo core.

[IMP] base_location: name_search improvement (OCA#585)

756e322

Translated using Weblate (Spanish)

6999387

Currently translated at 66.7% (24 of 36 strings) Translation: partner-contact-11.0/partner-contact-11.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_location/es/

Translated using Weblate (German)

93557cb

Currently translated at 100,0% (36 of 36 strings) Translation: partner-contact-11.0/partner-contact-11.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_location/de/

[IMP] base_location: Add migration scripts

5419d51

Translated using Weblate (Spanish)

2c3ad7e

Currently translated at 57.6% (19 of 33 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_location/es/

OCA-git-bot added a commit that referenced this pull request Oct 1, 2019

Merge PR #785 into 13.0

7adc562

Signed-off-by pedrobaeza

OCA-git-bot added a commit that referenced this pull request Oct 3, 2019

Merge PR #785 into 13.0

cc8ac48

Signed-off-by pedrobaeza

OCA-git-bot added a commit that referenced this pull request Oct 4, 2019

Merge PR #785 into 13.0

2d3d0a1

Signed-off-by pedrobaeza

OCA-git-bot added a commit that referenced this pull request Oct 4, 2019

Merge PR #785 into 13.0

80b954c

Signed-off-by sbidoul

OCA-git-bot added a commit that referenced this pull request Oct 4, 2019

Merge PR #785 into 13.0

ea2df2a

Signed-off-by sbidoul

OCA-git-bot merged commit 2fdc70e into OCA:13.0 Oct 4, 2019

OCA-git-bot added the merged 🎉 label Oct 4, 2019

pedrobaeza deleted the 13.0-base_location branch October 4, 2019 09:50

OCA-git-bot mentioned this pull request Oct 4, 2019

Migration to version 13.0 #783

Open

47 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0][MIG] base_location: Migration to 13.0 #785

[13.0][MIG] base_location: Migration to 13.0 #785

pedrobaeza commented Sep 30, 2019

pedrobaeza commented Oct 1, 2019

OCA-git-bot commented Oct 1, 2019

OCA-git-bot commented Oct 2, 2019

pedrobaeza commented Oct 3, 2019

OCA-git-bot commented Oct 3, 2019

OCA-git-bot commented Oct 3, 2019

pedrobaeza commented Oct 3, 2019

moylop260 commented Oct 3, 2019

pedrobaeza commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019

rousseldenis commented Oct 4, 2019

pedrobaeza commented Oct 4, 2019

sbidoul commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019

pedrobaeza commented Oct 4, 2019

sbidoul commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019

sbidoul commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019

[13.0][MIG] base_location: Migration to 13.0 #785

[13.0][MIG] base_location: Migration to 13.0 #785

Conversation

pedrobaeza commented Sep 30, 2019

pedrobaeza commented Oct 1, 2019

OCA-git-bot commented Oct 1, 2019

OCA-git-bot commented Oct 2, 2019

pedrobaeza commented Oct 3, 2019

OCA-git-bot commented Oct 3, 2019

OCA-git-bot commented Oct 3, 2019

pedrobaeza commented Oct 3, 2019

moylop260 commented Oct 3, 2019

pedrobaeza commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019

rousseldenis commented Oct 4, 2019

pedrobaeza commented Oct 4, 2019

sbidoul commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019

pedrobaeza commented Oct 4, 2019

sbidoul commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019

sbidoul commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019

OCA-git-bot commented Oct 4, 2019