Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] pylint_odoo: Supports odoo 13.0 #249

Merged
merged 2 commits into from
Aug 12, 2019

Conversation

moylop260
Copy link
Collaborator

@moylop260 moylop260 commented Jul 19, 2019

Odoo version 13.0 is coming soon

TODO:
Fixing missing unnecessary-utf8-coding-comment:

  • pylint_odoo/test_repo/broken_module3/__init__.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary

NOTE: Testing locally using
python3.7 -m pylint --load-plugins=pylint_odoo -d all -e unnecessary-utf8-coding-comment pylint_odoo/test_repo/broken_module3/__init__.py

UPDATE:
The TODO will be worked from:

@pedrobaeza
Copy link
Member

And why not adding in advance other future versions (14.0 and 15.0 for example) as well for not forgetting it each year?

@moylop260
Copy link
Collaborator Author

IMHO If all our (OCA) forgot update new odoo version. It means that this project will need die.
In fact, I can add a regex to support valid possible version but the idea of this is just use a current valid number.

@pedrobaeza
Copy link
Member

OK, as you prefer. I always forget this part in the yearly new version cycle, but if you are there, then no problem 😃

 - [REF] tox: Using npm from tox and clean requirements
 - [REF] pylint_odoo: Bypassing test with TODO note
 - [REF] no_modules: Fix flake8
@moylop260
Copy link
Collaborator Author

FYI It is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants