Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] web_favicon: Migration to 17.0 #2770

Merged
merged 34 commits into from
Apr 18, 2024

Conversation

dc-oerp
Copy link

@dc-oerp dc-oerp commented Mar 14, 2024

preserve commit history from V12 to V17

Previously in this PR:
#2765 (comment)

hbrunn and others added 30 commits March 14, 2024 13:34
Currently translated at 100,0% (9 of 9 strings)

Translation: web-11.0/web-11.0-web_favicon
Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_favicon/pt_BR/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 22.2% (2 of 9 strings)

Translation: web-12.0/web-12.0-web_favicon
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_favicon/pt/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-12.0/web-12.0-web_favicon
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_favicon/zh_CN/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-12.0/web-12.0-web_favicon
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_favicon/pt_BR/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-12.0/web-12.0-web_favicon
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_favicon/ca/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-12.0/web-12.0-web_favicon
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_favicon/es/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-12.0/web-12.0-web_favicon
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_favicon/tr/
Currently translated at 88.8% (8 of 9 strings)

Translation: web-12.0/web-12.0-web_favicon
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_favicon/de/
@dc-oerp
Copy link
Author

dc-oerp commented Mar 15, 2024

All fixed

@dc-oerp dc-oerp force-pushed the 17.0-mig-web_favicon branch 9 times, most recently from 9bf1e95 to 51438be Compare March 27, 2024 20:15
Copy link
Member

@ioans73 ioans73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat and working. Just few comments.

web_favicon/views/res_company_view.xml Outdated Show resolved Hide resolved
web_favicon/views/res_company_view.xml Outdated Show resolved Hide resolved
web_favicon/tests/__init__.py Outdated Show resolved Hide resolved
web_favicon/tests/__init__.py Outdated Show resolved Hide resolved
@dc-oerp dc-oerp force-pushed the 17.0-mig-web_favicon branch 3 times, most recently from 9201e4e to 02d8609 Compare April 15, 2024 14:02
@dc-oerp
Copy link
Author

dc-oerp commented Apr 15, 2024

Hi @pedrobaeza

Thanks for the comments.
I faced one issue where after I fixed the comments, and ran pre-commit locally, it passed without any issues.
However, after I pushed the code, it showed that there was an issue with Pylint.

Could you please take a look?

Thanks

"version": "17.0.1.0.0",
"author": "Therp BV, "
"Tecnativa, "
"OERP Canada"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"OERP Canada"
"OERP Canada,"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the previous image

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-2770-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a53d39b into OCA:17.0 Apr 18, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 48fe129. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.