-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Heel error when non-sensical units are used for a given measurement/observation #4
Comments
Currently, per convention 10 - unit is optional. This proposal still allows this to be missing, but for advanced sites provides Heel notifications and warnings. https://github.com/OHDSI/CommonDataModel/wiki/MEASUREMENT#conventions |
Well, an empty unit is totally correct for some tests, for example: haematocrit and other ratios. |
I believe for those unit ‘ratio’ should be used. There is nothing wrong with leaving it null though |
This overlaps with issue #28 (which was closed and subsumed into this one). ThemisMeasurements study was extended to include coded values and was renamed ThemisConcepts. |
For the hematocrit question, let's use the power of real world data and see what sites are using. So teams at 13 sites thought hard about how to standardize their lab data. And without ever meeting (those 13 teams) and debating for a very long time, we can look at an emerging group consensus (assuming each site is diligent about having their data analysis-ready and neat) see here - line 39 Let not forget that we try to eliminate ambiguity for a machine or analyst. And 0.47 or 47 (as %) make a 100 fold difference. |
So, basically we need to create relationships from Measurement to preffered unit in concept_relationship table, right? |
I like the idea to mandate the unit "1" or "{ratio}" or something like that.
I think that is future. Right now, we want to create mandatory (preferred as you call it) llist of units. |
Current: Measurements should have a concept set for acceptable units. Once instantiated, then DQD rules should be built. Future: We harmonize all value and units for a particular measurement to one, OHDSI blessed unit. This will be a recommendation. |
Working on DQD, we already created sets of permissible units per measurement concept.
It might seem to be too broad, but it's the way how to get values for a lot of measurements. What is your suggested approach? |
You should discuss this issue with @vojtechhuser since he is the creator or the original issue. I think you or Vojtech should be the owner of this issue. Let me know who it will be, so I can appropriately assign this issue. We need a clear description of the problem, the current use case, and approach to remedy the issue. We will also need guidance for the ETLer and for the end users of the data. Though I am not sure the latter is necessary, but the former definitely is since the DQD will generate an error for the non-sensical units. |
FORUM: http://forums.ohdsi.org/t/improved-data-quality-checking-for-measurement/5421
SOLUTION:
NEXT STEPS: modify conventions for MEASUREMENT table
Observed units per lab test: https://github.com/OHDSI/StudyProtocolSandbox/blob/master/themis/extras/results2019/S3-units-with-tests.csv
(for example see data for LOINC,8302-2 - height - cm (6 datasets), inches (2 datasets))
Data driven concensus KB for the second point:
https://github.com/OHDSI/StudyProtocolSandbox/blob/master/themis/extras/results2019/S7-preferred_units-ABC.csv
This issue will document the progress on it - or people to make comments.
ThemisUnits knowledge base will be used.
Proposal is to implement it as R logic (not in SQL). (VH volunteers to do that).
If SQL has to be used - I am making a call for volunteer SQL developer willing to help.
The text was updated successfully, but these errors were encountered: