Merge for release build #1614

mregen · 2021-11-25T08:14:25Z

No description provided.

Bumps [Serilog.Sinks.Console](https://github.com/serilog/serilog-sinks-console) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/serilog/serilog-sinks-console/releases) - [Commits](serilog/serilog-sinks-console@v4.0.0...v4.0.1) --- updated-dependencies: - dependency-name: Serilog.Sinks.Console dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

- the previous fix to remove TypeDefinitionId caused a regression with Alarms (#1574/#1576) - This is a backward compatible fix to remove the TypeDefintionId where it is not needed in the nodeset but still fill the MethodDeclarationId.

- ModelCompiler Fixes for MethodDeclarationId - Previous fix not only removed TypDefinitionId in certain cases but also removed the MethodDeclarationId - This backward compatible fix should work with old and new nodeset files

- The ci pass includes Roslynator checks, fails on warnings - Fix all existing warnings

* update the ref server models Using OPCFoundation/UA-ModelCompiler@167f905 + 1.4.368.68-preview Nuget

CLAassistant · 2021-11-25T08:14:32Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ opcfoundation-org
✅ mregen
❌ dependabot[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

lgtm-com · 2021-11-25T08:25:29Z

This pull request fixes 2 alerts when merging 38580ab into 58bbc0c - view on LGTM.com

fixed alerts:

2 for Constant condition

codecov · 2021-11-25T09:10:19Z

Codecov Report

Merging #1614 (b4fb5af) into release/1.4.367 (31e4a2b) will increase coverage by 0.01%.
The diff coverage is 3.37%.

❗ Current head b4fb5af differs from pull request most recent head edadaa8. Consider uploading reports for the commit edadaa8 to get more accurate results

@@                 Coverage Diff                 @@
##           release/1.4.367    #1614      +/-   ##
===================================================
+ Coverage            53.41%   53.42%   +0.01%     
===================================================
  Files                  312      312              
  Lines                57364    57367       +3     
===================================================
+ Hits                 30640    30649       +9     
+ Misses               26724    26718       -6

Impacted Files	Coverage Δ
....PubSub/Configuration/ConfigurationVersionUtils.cs	`5.26% <ø> (ø)`
...aries/Opc.Ua.PubSub/Transport/MqttClientCreator.cs	`0.00% <0.00%> (ø)`
Libraries/Opc.Ua.PubSub/Transport/UdpDiscovery.cs	`0.00% <0.00%> (ø)`
...s/Opc.Ua.PubSub/Transport/UdpDiscoveryPublisher.cs	`0.00% <0.00%> (ø)`
.../Opc.Ua.PubSub/Transport/UdpDiscoverySubscriber.cs	`0.00% <0.00%> (ø)`
...ies/Opc.Ua.PubSub/Transport/UdpPubSubConnection.cs	`30.00% <0.00%> (ø)`
Stack/Opc.Ua.Core/Schema/UANodeSet.cs	`37.34% <0.00%> (-0.28%)`	⬇️
Stack/Opc.Ua.Core/Schema/UANodeSetHelpers.cs	`46.38% <0.00%> (ø)`
...tack/Opc.Ua.Core/Stack/Generated/Opc.Ua.Classes.cs	`25.00% <ø> (ø)`
Stack/Opc.Ua.Core/Stack/Nodes/ContentFilter.cs	`5.27% <0.00%> (ø)`
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e4a2b...edadaa8. Read the comment docs.

mrsuciu · 2021-11-25T12:16:23Z

Method instances contain HasTypeDefinition references

mregen · 2021-11-25T12:39:38Z

lets wait until confirmed that the nodeset is now correct

* update package to 6.0 * bump

lgtm-com · 2021-11-29T09:12:38Z

This pull request fixes 2 alerts when merging 47370a9 into 58bbc0c - view on LGTM.com

fixed alerts:

2 for Constant condition

Bumps [Roslynator.Analyzers](https://github.com/JosefPihrt/Roslynator) from 3.2.2 to 3.3.0. - [Release notes](https://github.com/JosefPihrt/Roslynator/releases) - [Changelog](https://github.com/JosefPihrt/Roslynator/blob/master/ChangeLog.md) - [Commits](dotnet/roslynator@v3.2.2...v3.3.0) --- updated-dependencies: - dependency-name: Roslynator.Analyzers dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

lgtm-com · 2021-11-29T11:24:30Z

This pull request fixes 2 alerts when merging 17d80b6 into 58bbc0c - view on LGTM.com

fixed alerts:

2 for Constant condition

Bumps [NUnit.Console](https://github.com/nunit/nunit-console) from 3.12.0 to 3.13.0. - [Release notes](https://github.com/nunit/nunit-console/releases) - [Changelog](https://github.com/nunit/nunit-console/blob/master/CHANGES.txt) - [Commits](nunit/nunit-console@v3.12...3.13) --- updated-dependencies: - dependency-name: NUnit.Console dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

lgtm-com · 2021-12-03T06:25:49Z

This pull request fixes 2 alerts when merging b0d510b into 58bbc0c - view on LGTM.com

fixed alerts:

2 for Constant condition

Bumps [MQTTnet](https://github.com/chkr1011/MQTTnet) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/chkr1011/MQTTnet/releases) - [Commits](dotnet/MQTTnet@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: MQTTnet dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

lgtm-com · 2021-12-03T08:50:33Z

This pull request fixes 2 alerts when merging b4fb5af into 58bbc0c - view on LGTM.com

fixed alerts:

2 for Constant condition

* Revert MethodDeclarationId change due to breaking code. * Delete duplicate of Opc.Ua.Nodeset2.xml Co-authored-by: Randy Armstrong <randy@sparhawksoftware.com> Co-authored-by: Martin Regen <mregen@microsoft.com>

lgtm-com · 2021-12-03T11:00:45Z

This pull request fixes 2 alerts when merging edadaa8 into 58bbc0c - view on LGTM.com

fixed alerts:

2 for Constant condition

dependabot bot and others added 5 commits November 22, 2021 07:47

Fix export of TypeDefinitionId (#1604)

486e97b

- the previous fix to remove TypeDefinitionId caused a regression with Alarms (#1574/#1576) - This is a backward compatible fix to remove the TypeDefintionId where it is not needed in the nodeset but still fill the MethodDeclarationId.

Enforce Roslynator checks in CI build (#1608)

2430a65

- The ci pass includes Roslynator checks, fails on warnings - Fix all existing warnings

Models generated by latest ModelCompiler (#1613)

38580ab

* update the ref server models Using OPCFoundation/UA-ModelCompiler@167f905 + 1.4.368.68-preview Nuget

mregen requested a review from mrsuciu November 25, 2021 08:14

mrsuciu approved these changes Nov 25, 2021

View reviewed changes

mregen marked this pull request as draft November 25, 2021 18:12

mregen added this to the 1.4.367 milestone Nov 28, 2021

Bump up Nuget packages to 6.0.0 (#1617)

47370a9

* update package to 6.0 * bump

Revert MethodDeclarationId change due to breaking code. (#1615)

edadaa8

* Revert MethodDeclarationId change due to breaking code. * Delete duplicate of Opc.Ua.Nodeset2.xml Co-authored-by: Randy Armstrong <randy@sparhawksoftware.com> Co-authored-by: Martin Regen <mregen@microsoft.com>

mregen marked this pull request as ready for review December 3, 2021 11:13

mregen merged commit cc1b368 into release/1.4.367 Dec 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge for release build #1614

Merge for release build #1614

mregen commented Nov 25, 2021

CLAassistant commented Nov 25, 2021 •

edited

lgtm-com bot commented Nov 25, 2021

codecov bot commented Nov 25, 2021 •

edited

mrsuciu commented Nov 25, 2021

mregen commented Nov 25, 2021

lgtm-com bot commented Nov 29, 2021

lgtm-com bot commented Nov 29, 2021

lgtm-com bot commented Dec 3, 2021

lgtm-com bot commented Dec 3, 2021

lgtm-com bot commented Dec 3, 2021

Merge for release build #1614

Merge for release build #1614

Conversation

mregen commented Nov 25, 2021

CLAassistant commented Nov 25, 2021 • edited

lgtm-com bot commented Nov 25, 2021

codecov bot commented Nov 25, 2021 • edited

Codecov Report

mrsuciu commented Nov 25, 2021

mregen commented Nov 25, 2021

lgtm-com bot commented Nov 29, 2021

lgtm-com bot commented Nov 29, 2021

lgtm-com bot commented Dec 3, 2021

lgtm-com bot commented Dec 3, 2021

lgtm-com bot commented Dec 3, 2021

CLAassistant commented Nov 25, 2021 •

edited

codecov bot commented Nov 25, 2021 •

edited