Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contour plots: Fix number format #6971

Closed
wants to merge 1 commit into from
Closed

Contour plots: Fix number format #6971

wants to merge 1 commit into from

Conversation

jonjenssen
Copy link
Collaborator

Closes #6913

@jonjenssen jonjenssen linked an issue Nov 11, 2020 that may be closed by this pull request
Bugs with contour map lines #6913
Closed
magnesj
magnesj requested changes Nov 12, 2020
View reviewed changes
Copy link
Member

@magnesj magnesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more robust to access m_contourMapProjection->legendConfig(), and use the settings in RimRegularLegendConfig when producing text.

See m_precision and m_tickNumberFormat in RimRegularLegendConfig. These are not available in the interface, so consider exposing them or create a helper function to format a text string based on a double value

@magnesj
Copy link
Member

magnesj commented Dec 1, 2020

Fixed by 3d0c1e3 similar to my review comment above

@magnesj magnesj closed this Dec 1, 2020
@jonjenssen jonjenssen deleted the contourplot_format branch February 11, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnesj magnesj magnesj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugs with contour map lines
2 participants
@jonjenssen @magnesj