Skip to content

v3.5.0 — Security release (manifest 4.8.1)

Choose a tag to compare

@ORDNET ORDNET released this 11 Aug 18:31
· 20 commits to main since this release
cba65b9
  • A listing now pays the seller shown on the approval screen. The check used
    to compare two values that both came from the calling page.
  • 4.8.1 supersedes 4.8.0 the same day: review of that build found the listing
    check still comparing params against params. Do not ship 4.8.0.

Fixes three critical issues from an external review, plus two patterns that
recurred across the codebase.

K5 — the approval screen rendered outputs[] and the service fee, and nothing
else. Not the change address, not the fee. A site could name a changeAddress
of its own and the entire remainder of the selected UTXOs would leave the
wallet behind a screen reading "1.000 sats". Both are now always shown; a
foreign change address is flagged in red with an explanation. Script outputs
disclose their destination, inscription outputs their receiving address.

K6 — the viewer iframe carried allow-scripts together with allow-same-origin,
which cancels the sandbox: a srcdoc document inherits the extension origin.
Since viewer.html is web-accessible from every site, any page could open it
against an inscription of the attacker's choosing and read the session key.
allow-same-origin is removed. The service worker now sends nosniff and
replaces content types outside a render allowlist.

K7 — signMessage was exposed unfiltered to every page while the same primitive
builds registry authentication, so a site could have a domain transfer signed
under a screen that read "No coins move." Page-originated signing now refuses
messages in reserved namespaces; internal signAction is unchanged and the
registry keeps working. The approval screen states what a signature can do and
shows the message in full instead of silently cutting it at 200 characters.

Pattern: ordinal protection was value > 1 only, so any ordinal with padding
was spendable as funding — while the wallet already held the inscription
outpoints in its loaded holdings. Those are now used.

Pattern: four call sites used (fee|0), a 32-bit cast, three lines below the
file's own warning against it. feeNum() replaces all of them.

Tests: 123 -> 167 across ten suites. Full detail in SECURITY-FIXES-4.8.0.md.