Created VSIError to report VSI errors.

[lossyrob]

Implements virtual file system error reporting, and sets errors on unix file IO errors and certain AWS S3 errors.

More documentation to follow.

• Implement error reporting
• Testing
• Test against windows to check against correct file system error string.

[lossyrob]

/cc @sgillies @rouault @perrygeo

This is the initial set of work, I couldn't get all the testing done before having to say Au Revoir at the OSGeo code sprint.

My editor strips endline whitespace, sorry for the diff noise; if you need that to not happen just let me know and I can fix it.

[lossyrob]

Thanks for the notes Even. I'll make these changes when I can get back to this, and also figure out what's going with the autotests (I tried running on a clean checkout and getting the same segfault). I think my approach will be to try and have some docker images that can build and test, for OSX hacks like me. It'll be a couple of weeks because I'm under the gun for a GeoTrellis release.

Does GDAL have a release schedule, so I know when I'll have to get this in by?

[rouault]

Does GDAL have a release schedule, so I know when I'll have to get this in by?
For now, the feature freeze is planned end of March, but there's also a chance/risk that it is advanced on March 11th to please a potential "sponsor" (should know very soon hopefully)

[sgillies]

@rouault Which feature freeze is planned for the end of March? Are you talking about a 2.1 freeze? It's worth my time to get @lossyrob's work into 2.1.

[rouault]

Are you talking about a 2.1 freeze?

Yes

[lossyrob]

End of March is doable for me, but if it gets pushed up to March 11 it'll be a tight fit. @sgillies besides the code comments I just need to test, so if your willing to throw time at it it would be a matter of getting the tests running and passing.

[rouault]

End of March is doable for me, but if it gets pushed up to March 11 it'll be a tight fit.

Update: forget my mention of March 11. End of March for feature freeze is still the current target.

[sgillies]

Thanks, @rouault!

[lossyrob]

@rouault My latest commits address your code review comments, thanks. I'm going to be working on getting the tests running and finish up any additional changes today.

[rouault]

I'm afraid this will not pass on Windows

[lossyrob]

True. I got the impression that the autotest was only running on Linux (it still fails my mac in some ways, even trunk, whereas Travis passes). Are the autotests targeted to work across all platforms? If so, do you have suggestions on how to test on Windows?

[rouault]

The autotest also run on Windows and Mac.
For Windows, there's an AppVeyor config in this branch : https://github.com/rouault/gdal_coverage/blob/trunk_vc12_full/appveyor.yml . It could/should probably be merged into main repo. For now, master is merged regularly in this branch.
For Mac, this is https://github.com/rouault/gdal_coverage/blob/trunk_travis_macosx/.travis.yml . Could probably be unified into the main travis.yml with some matrix logic.
With the current setup, I guess you could probably fork that repo and merge your branch into the 2 above branches, and create PR to trigger the builds ?

[lossyrob]

Ok, I'll give that a shot once I get the travis build to pass in this repo.

[lossyrob]

Actually, the way you have the branches set up, I don't believe that will work. I'll try to find another way to test on Windows.

[lossyrob]

@rouault tests are passing on Travis, and I set up a window build that passed here: https://ci.appveyor.com/project/lossyrob/gdal-coverage/build/job/hr5k8fm2n36j4sya. I believe this PR is ready for merge. Thanks!

[rouault]

Committed in r33758

[rouault]

Everything looks good with the buildbots. Closing