Skip to content

v7.2.6

Choose a tag to compare

@OSXBasedAnon OSXBasedAnon released this 21 Jan 22:20
· 628 commits to main since this release
b111691

Fix connection issue and improve handshake debugging

The problem stemmed from the incorrect use of non-blocking sockets in the connection setup. Additionally, comprehensive logging has been added to the perform_handshake function to facilitate easier debugging of future handshake issues.

Changes:

  • Removed sock.set_nonblocking(true); from configure_tcp_socket. This ensures the use of blocking sockets, which is essential for the current handshake implementation using read_exact and write_all.
  • Implemented extensive logging within perform_handshake:
    • Logs the raw bytes of serialized messages before sending and after receiving.
    • Logs the deserialized HandshakeMessage objects.
    • Logs any errors encountered during serialization or deserialization.
    • Added logging to validate_handshake for key values and signature verification.

Testing:

  • Manual testing of node connections has been conducted to verify successful communication following these changes.

Additional Notes:

  • The detailed logging introduced in this PR will be instrumental in diagnosing any future handshake-related problems.